Subject: Re: [PATCH 3/3] genetlink: synchronize socket closing and family removal

From: Johannes Berg <[email-masked]>
Date: Thu, 15 Jan 2015 21:55:06 +0100

On Thu, 2015-01-15 at 14:50 -0500, David Miller wrote:
> From: Johannes Berg <[email-masked]>
> Date: Thu, 15 Jan 2015 12:04:45 +0100
> 
> > +		atomic_dec(&genl_sk_destructing_cnt);
> > +		printk(KERN_DEBUG "dec destructing\n");
> > +		wake_up(&genl_sk_destructing_waitq);
> 
> Hmmm, maybe only wakeup if "!atomic_dec_and_test()"?

Yes, good point.

And, umm, how the hell did I manage to leave the printk() in there?

johannes