From: Johannes Berg <johannes@sipsolutions•net>
To: "Rémi Denis-Courmont" <remi@remlab•net>
Cc: netdev@vger•kernel.org, Sakari Ailus <sakari.ailus@nokia•com>,
Remi Denis-Courmont <courmisch@gmail•com>
Subject: Re: [PATCH] phonet netlink: allow multiple messages per skb in route dump
Date: Mon, 19 Jan 2015 21:14:44 +0100 [thread overview]
Message-ID: <1421698484.1965.44.camel@sipsolutions.net> (raw)
In-Reply-To: <45863435.BJJN05sX3K@philogene>
On Mon, 2015-01-19 at 22:11 +0200, Rémi Denis-Courmont wrote:
> Le lundi 19 janvier 2015, 12:15:24 Johannes Berg a écrit :
> > From: Johannes Berg <johannes.berg@intel•com>
> >
> > My previous patch to this file changed the code to be bug-compatible
> > towards userspace. Unless userspace (which I wasn't able to find)
> > implements the dump reader by hand in a wrong way, this isn't needed.
>
> The canonical userspace is there (specifically src/pnroute.c):
> https://gitorious.org/meego-cellular/phonet-utils/
Ah, cool.
> AFAICT, it should work either way. By now, I expect what's left of the
> Maemo/Meego/Mer/whatever community has forked or rewritten it though.
The loop
for (struct nlmsghdr *nlh = (struct nlmsghdr *)&req;
NLMSG_OK (nlh, (size_t)ret); nlh = NLMSG_NEXT (nlh, ret))
should make it do the right thing, I agree.
johannes
next prev parent reply other threads:[~2015-01-19 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 11:15 [PATCH] phonet netlink: allow multiple messages per skb in route dump Johannes Berg
2015-01-19 20:11 ` Rémi Denis-Courmont
2015-01-19 20:14 ` Johannes Berg [this message]
2015-01-19 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421698484.1965.44.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=courmisch@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=remi@remlab$(echo .)net \
--cc=sakari.ailus@nokia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox