From: Joe Perches <joe@perches•com>
To: erik.hugne@ericsson•com
Cc: richard.alpe@ericsson•com, netdev@vger•kernel.org,
jon.maloy@ericsson•com, ying.xue@windriver•com,
tipc-discussion@lists•sourceforge.net
Subject: Re: [PATCH net-next 1/2] tipc: fix excessive network event logging
Date: Thu, 22 Jan 2015 09:24:47 -0800 [thread overview]
Message-ID: <1421947487.2702.1.camel@perches.com> (raw)
In-Reply-To: <1421943032-29924-1-git-send-email-erik.hugne@ericsson.com>
On Thu, 2015-01-22 at 17:10 +0100, erik.hugne@ericsson•com wrote:
> From: Erik Hugne <erik.hugne@ericsson•com>
>
> If a large number of namespaces is spawned on a node and TIPC is
> enabled in each of these, the excessive printk tracing of network
> events will cause the system to grind down to a near halt.
> The traces are still of debug value, so instead of removing them
> completely we fix it by changing the link state and node availability
> logging debug traces.
Maybe some of these should be net_<level>_ratelimited(fmt, ...)
> diff --git a/net/tipc/link.c b/net/tipc/link.c
[]
> @@ -588,8 +588,8 @@ static void link_state_event(struct tipc_link *l_ptr, unsigned int event)
> l_ptr->fsm_msg_cnt++;
> link_set_timer(l_ptr, cont_intv / 4);
> } else { /* Link has failed */
> - pr_warn("%s<%s>, peer not responding\n",
> - link_rst_msg, l_ptr->name);
Like this one.
> + pr_debug("%s<%s>, peer not responding\n",
> + link_rst_msg, l_ptr->name);
> tipc_link_reset(l_ptr);
> l_ptr->state = RESET_UNKNOWN;
> l_ptr->fsm_msg_cnt = 0;
> @@ -380,8 +380,8 @@ static void node_lost_contact(struct tipc_node *n_ptr)
> char addr_string[16];
> u32 i;
>
> - pr_info("Lost contact with %s\n",
> - tipc_addr_string_fill(addr_string, n_ptr->addr));
> + pr_debug("Lost contact with %s\n",
> + tipc_addr_string_fill(addr_string, n_ptr->addr));
>
> /* Flush broadcast link info associated with lost node */
> if (n_ptr->bclink.recv_permitted) {
And maybe this one too.
next prev parent reply other threads:[~2015-01-22 17:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:10 [PATCH net-next 1/2] tipc: fix excessive network event logging erik.hugne
2015-01-22 16:10 ` [PATCH net-next 2/2] flow_dissector: add tipc support erik.hugne
2015-01-22 17:29 ` Eric Dumazet
2015-01-22 18:38 ` Jon Maloy
2015-01-27 0:57 ` David Miller
2015-01-27 12:08 ` Erik Hugne
2015-01-27 14:40 ` Eric Dumazet
2015-01-27 1:04 ` David Miller
2015-01-22 17:24 ` Joe Perches [this message]
2015-01-23 6:44 ` [PATCH net-next 1/2] tipc: fix excessive network event logging Erik Hugne
2015-01-27 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421947487.2702.1.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=erik.hugne@ericsson$(echo .)com \
--cc=jon.maloy@ericsson$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard.alpe@ericsson$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox