From: "Keller, Jacob E" <jacob.e.keller@intel•com>
To: "richardcochran@gmail•com" <richardcochran@gmail•com>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"baolin.wang@linaro•org" <baolin.wang@linaro•org>,
"b45643@freescale•com" <b45643@freescale•com>,
"amirv@mellanox•com" <amirv@mellanox•com>,
"peppe.cavallaro@st•com" <peppe.cavallaro@st•com>,
"sonic.zhang@analog•com" <sonic.zhang@analog•com>,
"rayagond@vayavyalabs•com" <rayagond@vayavyalabs•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"sony.chacko@qlogic•com" <sony.chacko@qlogic•com>,
"Vick, Matthew" <matthew.vick@intel•com>,
"arnd@linaro•org" <arnd@linaro•org>,
"Frank.Li@freescale•com" <Frank.Li@freescale•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"mchan@broadcom•com" <mchan@broadcom•com>,
"prashant@broadcom•com" <prashant@broadcom•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"john.stultz@linaro•org" <john.stultz@linaro•org>
Subject: Re: [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse
Date: Tue, 31 Mar 2015 21:11:30 +0000 [thread overview]
Message-ID: <1427836290.16312.29.camel@intel.com> (raw)
In-Reply-To: <cover.1427835485.git.richardcochran@gmail.com>
On Tue, 2015-03-31 at 23:08 +0200, Richard Cochran wrote:
> This patch series is a follow up to the recent timespec64 work for the
> PTP Hardware Clock drivers. Arnd noticed that drivers are using open
> coded implementations of ns_to_timespec64 and timespec64_to_ns. This
> series replaces the open coded logic with the helper functions.
>
> Thanks,
> Richard
>
> Richard Cochran (11):
> ptp: blackfin: use helpers for converting ns to timespec.
> ptp: bnx2x: use helpers for converting ns to timespec.
> ptp: tg3: use helpers for converting ns to timespec.
> ptp: fec: use helpers for converting ns to timespec.
> ptp: gianfar: use helpers for converting ns to timespec.
> ptp: e1000e: use helpers for converting ns to timespec.
> ptp: igb: use helpers for converting ns to timespec.
> ptp: ixgbe: use helpers for converting ns to timespec.
> ptp: mlx4: use helpers for converting ns to timespec.
> ptp: stmmac: use helpers for converting ns to timespec.
> ptp: cpts: use helpers for converting ns to timespec.
>
> drivers/net/ethernet/adi/bfin_mac.c | 8 +++-----
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 7 ++-----
> drivers/net/ethernet/broadcom/tg3.c | 4 +---
> drivers/net/ethernet/freescale/fec_ptp.c | 7 ++-----
> drivers/net/ethernet/freescale/gianfar_ptp.c | 8 +++-----
> drivers/net/ethernet/intel/e1000e/ptp.c | 4 +---
> drivers/net/ethernet/intel/igb/igb_ptp.c | 7 ++-----
> drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 7 ++-----
> drivers/net/ethernet/mellanox/mlx4/en_clock.c | 4 +---
> drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 +---
> drivers/net/ethernet/ti/cpts.c | 7 ++-----
> 11 files changed, 20 insertions(+), 47 deletions(-)
>
For all the Intel drivers, this looks fine. I'm surprised I never
noticed before.
Acked-by: Jacob Keller <jacob.e.keller@intel•com>
next prev parent reply other threads:[~2015-03-31 21:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 21:08 [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 01/11] ptp: blackfin: use helpers for converting ns to timespec Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 02/11] ptp: bnx2x: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 03/11] ptp: tg3: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 04/11] ptp: fec: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 05/11] ptp: gianfar: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 06/11] ptp: e1000e: " Richard Cochran
2015-03-31 21:10 ` Keller, Jacob E
2015-03-31 21:08 ` [PATCH net-next 07/11] ptp: igb: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 08/11] ptp: ixgbe: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 09/11] ptp: mlx4: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 10/11] ptp: stmmac: " Richard Cochran
2015-03-31 21:08 ` [PATCH net-next 11/11] ptp: cpts: " Richard Cochran
2015-03-31 21:11 ` Keller, Jacob E [this message]
2015-03-31 21:38 ` [PATCH net-next 00/11] remove open coded ns_to_timespec64 and reverse Richard Cochran
2015-03-31 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427836290.16312.29.camel@intel.com \
--to=jacob.e.keller@intel$(echo .)com \
--cc=Frank.Li@freescale$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=arnd@linaro$(echo .)org \
--cc=b45643@freescale$(echo .)com \
--cc=baolin.wang@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=john.stultz@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=matthew.vick@intel$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=prashant@broadcom$(echo .)com \
--cc=rayagond@vayavyalabs$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sonic.zhang@analog$(echo .)com \
--cc=sony.chacko@qlogic$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox