Subject: Re: [PATCH net-next 1/2] ipv4: coding style: comparison for equality with NULL

From: Joe Perches <[email-masked]>
Date: Fri, 03 Apr 2015 09:51:15 -0700

On Fri, 2015-04-03 at 09:17 +0100, Ian Morris wrote:
> The ipv4 code uses a mixture of coding styles. In some instances check
> for NULL pointer is done as x == NULL and sometimes as !x. !x is
> preferred according to checkpatch and this patch makes the code
> consistent by adopting the latter form.

Thanks Ian.

>  39 files changed, 210 insertions(+), 202 deletions(-)

A change like this would generally not add or remove lines.

It'd be nice if in the future, when a substitution like
this occurs and lines counts are changed that the commit
log states why.

For this case, maybe something like:

Hoisted a few assignments from if statements while there.