From: Joe Perches <joe@perches•com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail•com>
Cc: apw@canonical•com, davem@davemloft•net, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/2] checkpatch: suggest using ether_addr_equal*()
Date: Sun, 19 Apr 2015 13:23:01 -0700 [thread overview]
Message-ID: <1429474981.2947.36.camel@perches.com> (raw)
In-Reply-To: <1429470246-15988-2-git-send-email-mateusz.kulikowski@gmail.com>
On Sun, 2015-04-19 at 21:04 +0200, Mateusz Kulikowski wrote:
> Check if memcmp() is used to compare ethernet addresses and suggest using
> ether_addr_equal() or ether_addr_equal_unaligned()
Hi again Mateusz.
This is OK with me.
If you ever submit that ether_addr_copy_unaligned patch,
please update the checkpatch test for ether_addr_copy too.
Joe
next prev parent reply other threads:[~2015-04-19 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 19:04 [PATCH 0/2] checkpatch: new ethernet address manipulation checks Mateusz Kulikowski
2015-04-19 19:04 ` [PATCH 1/2] checkpatch: suggest using ether_addr_equal*() Mateusz Kulikowski
2015-04-19 20:23 ` Joe Perches [this message]
2015-04-19 19:04 ` [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() Mateusz Kulikowski
2015-04-19 20:20 ` Joe Perches
2015-04-19 22:01 ` Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429474981.2947.36.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=apw@canonical$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mateusz.kulikowski@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox