Subject: Re: [PATCH net-next] be2net: log link status

From: Joe Perches <[email-masked]>
Date: Wed, 22 Apr 2015 06:10:55 -0700

On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
> The driver unlike other drivers does not log link state changes.
[]
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
[]
> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>  		netif_carrier_on(netdev);
>  	else
>  		netif_carrier_off(netdev);
> +
> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>  }

If this is valuable, it's also valuable to emit the
link speed/duplex states like most other drivers.