Subject: Re: [PATCH net-next v5 20/21] rocker: make checkpatch -f clean

From: Joe Perches <[email-masked]>
Date: Tue, 05 May 2015 11:22:56 -0700

On Tue, 2015-05-05 at 10:34 -0700, [email-masked] wrote:
[]
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c

trivia:

> @@ -4699,8 +4704,9 @@ static int rocker_port_poll_tx(struct napi_struct *napi, int budget)
>  		if (err == 0) {
>  			rocker_port->dev->stats.tx_packets++;
>  			rocker_port->dev->stats.tx_bytes += skb->len;
> -		} else
> +		} else {
>  			rocker_port->dev->stats.tx_errors++;
> +		}

This might be sped up a bit with a likely

		if (likely(!err)) {
			rocker_port->dev->stats.tx_packets++;
			rocker_port->dev->stats.tx_bytes += skb->len;
		} else {
			rocker_port->dev->stats.tx_errors++;
		}