Subject: Re: [PATCH net-next v1 2/7] amd-xgbe: Add netif_msg_* support for driver messages

From: Joe Perches <[email-masked]>
Date: Tue, 12 May 2015 12:44:48 -0700

On Tue, 2015-05-12 at 14:22 -0500, Tom Lendacky wrote:
> Add support for the network interface message level settings for
> determining whether to issue some of the driver messages.

[]

> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c b/drivers/net/ethernet/amd/xgbe/xgbe-dcb.c
[]
> @@ -150,9 +150,14 @@ static int xgbe_dcb_ieee_setets(struct net_device *netdev,
>  	tc_ets = 0;
>  	tc_ets_weight = 0;
>  	for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) {
> -		DBGPR("  TC%u: tx_bw=%hhu, rx_bw=%hhu, tsa=%hhu\n", i,
> -		      ets->tc_tx_bw[i], ets->tc_rx_bw[i], ets->tc_tsa[i]);
> -		DBGPR("  PRIO%u: TC=%hhu\n", i, ets->prio_tc[i]);
> +		if (netif_msg_drv(pdata)) {
> +			netdev_dbg(netdev,
> +				   "TC%u: tx_bw=%hhu, rx_bw=%hhu, tsa=%hhu\n",
> +				   i, ets->tc_tx_bw[i], ets->tc_rx_bw[i],
> +				   ets->tc_tsa[i]);

These might be more concise and work a bit easier
with dynamic_debug using

	netif_dbg(priv, type, netdev, fmt, ...)

like:

		netif_dbg(pdata, drv, netdev,
			  "TC%u: tx_bw=%hhu, rx_bw=%hhu, tsa=%hhu\n",
			  i, ets->tc_tx_bw[i], ets->tc_rx_bw[i], ets->tc_tsa[i]);