From: Joe Perches <joe@perches•com>
To: Harish Patil <harish.patil@qlogic•com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic•com>
Cc: Dept-GELinuxNICDev@qlogic•com, linux-driver@qlogic•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: [PATCH] qlge: Move jiffies_to_usecs immediately before loop
Date: Tue, 19 May 2015 21:44:52 -0700 [thread overview]
Message-ID: <1432097092.2870.266.camel@perches.com> (raw)
30 usecs (or really, 1 jiffy) can go by pretty fast.
Move the set of the timeout immediately before the loop.
Remove the unnecessary max(1ul, usecs_to_jiffies(30)) as
usecs_to_jiffies with a non-zero constant is guaranteed
to be non-zero.
Signed-off-by: Joe Perches <joe@perches•com>
---
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 25800a1..02b7115 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -3871,9 +3871,6 @@ static int ql_adapter_reset(struct ql_adapter *qdev)
return status;
}
- end_jiffies = jiffies +
- max((unsigned long)1, usecs_to_jiffies(30));
-
/* Check if bit is set then skip the mailbox command and
* clear the bit, else we are in normal reset process.
*/
@@ -3888,6 +3885,7 @@ static int ql_adapter_reset(struct ql_adapter *qdev)
ql_write32(qdev, RST_FO, (RST_FO_FR << 16) | RST_FO_FR);
+ end_jiffies = jiffies + usecs_to_jiffies(30);
do {
value = ql_read32(qdev, RST_FO);
if ((value & RST_FO_FR) == 0)
next reply other threads:[~2015-05-20 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 4:44 Joe Perches [this message]
2015-05-20 23:17 ` [PATCH] qlge: Move jiffies_to_usecs immediately before loop Harish Patil
2015-05-21 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432097092.2870.266.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=Dept-GELinuxNICDev@qlogic$(echo .)com \
--cc=harish.patil@qlogic$(echo .)com \
--cc=linux-driver@qlogic$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sudarsana.kalluru@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox