Subject: Re: [net-next 07/17] fm10k: use an unsigned int for i in ethtool_get_strings

From: "Keller, Jacob E" <[email-masked]>
Date: Tue, 16 Jun 2015 20:37:56 +0000

On Tue, 2015-06-16 at 13:33 -0700, Jacob E Keller wrote:
> On Tue, 2015-06-16 at 17:19 +0300, Sergei Shtylyov wrote:
> > On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
> > 
> > > From: Jacob Keller <[email-masked]>
> > 
> > > The value will never be negative, and we use the %i print format, 
> > > 
> > > use
> > 
> >     "%i" is the same as "%d", AFAIR. You need "%u" for the unsigned 
> > 
> > variables.
> > 
> > > unsigned int for the loop counter. Issue found using cppcheck.
> > 
> > > Signed-off-by: Jacob Keller <[email-masked]>
> > > Tested-by: Krishneil Singh <[email-masked]>
> > > Signed-off-by: Jeff Kirsher <[email-masked]>
> > 
> > WBR, Sergei
> > 
> 
> Oops, you are right.
> 
> Regards,
> Jake

The actual code does use %u, but I made a typo in the description. I am
sending an rc2.

Regards,
Jake