From: Punit Vara <punitvara@gmail•com>
To: kvalo@qca•qualcomm.com
Cc: stas.yakovlev@gmail•com, chaoming_li@realsil•com.cn,
Larry.Finger@lwfinger•net, chunkeey@googlemail•com,
sgruszka@redhat•com, brudley@broadcom•com, arend@broadcom•com,
linville@tuxdriver•com, jirislaby@gmail•com, mickflemm@gmail•com,
mcgrof@do-not-panic•com, k.eugene.e@gmail•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
brcm80211-dev-list@broadcom•com, wcn36xx@lists•infradead.org,
johannes.berg@intel•com, meuleman@broadcom•com,
Punit Vara <punitvara@gmail•com>
Subject: [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result()
Date: Wed, 21 Oct 2015 20:25:32 +0530 [thread overview]
Message-ID: <1445439337-19055-11-git-send-email-punitvara@gmail.com> (raw)
In-Reply-To: <1445439337-19055-1-git-send-email-punitvara@gmail.com>
This patch is to the carl9170/phy.c file that fixes warning reported by
coccicheck :
WARNING: end returns can be simplified
I have removed unneccessary variable declaration and simply return flow
for carl9170_regwrite_result()
Signed-off-by: Punit Vara <punitvara@gmail•com>
---
drivers/net/wireless/ath/carl9170/phy.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c
index dca6df1..f3b5434 100644
--- a/drivers/net/wireless/ath/carl9170/phy.c
+++ b/drivers/net/wireless/ath/carl9170/phy.c
@@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = {
static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
u32 freq, enum carl9170_bw bw)
{
- int err;
u32 d0, d1, td0, td1, fd0, fd1;
u8 chansel;
u8 refsel0 = 1, refsel1 = 0;
@@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
carl9170_regwrite(0x1c58e8, fd1);
carl9170_regwrite_finish();
- err = carl9170_regwrite_result();
- if (err)
- return err;
-
- return 0;
+ return carl9170_regwrite_result();
}
static const struct carl9170_phy_freq_params *
--
2.5.3
next prev parent reply other threads:[~2015-10-21 14:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 14:55 [PATCH 00/15] Fix warnings reported by coccicheck Punit Vara
2015-10-21 14:55 ` [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:58 ` Jiri Slaby
2015-10-21 21:43 ` Sergei Shtylyov
2015-10-22 18:22 ` punit vara
2015-10-21 14:55 ` [PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon Punit Vara
2015-10-21 14:55 ` [PATCH 03/15] " Punit Vara
2015-10-21 14:55 ` [PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:55 ` [PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara
2015-10-21 15:40 ` kbuild test robot
2015-10-21 14:55 ` [PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara
2015-10-21 14:55 ` [PATCH 07/15] net: wireless: brcm80211: " Punit Vara
2015-10-21 14:55 ` [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara
2015-10-21 15:00 ` Jiri Slaby
2015-10-21 18:05 ` punit vara
2015-10-21 14:55 ` [PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara
2015-10-21 14:55 ` Punit Vara [this message]
2015-10-21 14:55 ` [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret Punit Vara
2015-10-21 21:45 ` Sergei Shtylyov
2015-10-21 14:55 ` [PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara
2015-10-21 14:55 ` [PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara
2015-10-21 14:55 ` [PATCH 14/15] net: wireless: ath: Remove unneeded variable ret " Punit Vara
2015-10-21 14:55 ` [PATCH 15/15] " Punit Vara
2015-10-21 21:46 ` Sergei Shtylyov
2015-10-22 18:23 ` punit vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445439337-19055-11-git-send-email-punitvara@gmail.com \
--to=punitvara@gmail$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=arend@broadcom$(echo .)com \
--cc=brcm80211-dev-list@broadcom$(echo .)com \
--cc=brudley@broadcom$(echo .)com \
--cc=chaoming_li@realsil$(echo .)com.cn \
--cc=chunkeey@googlemail$(echo .)com \
--cc=jirislaby@gmail$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=k.eugene.e@gmail$(echo .)com \
--cc=kvalo@qca$(echo .)qualcomm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=mcgrof@do-not-panic$(echo .)com \
--cc=meuleman@broadcom$(echo .)com \
--cc=mickflemm@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sgruszka@redhat$(echo .)com \
--cc=stas.yakovlev@gmail$(echo .)com \
--cc=wcn36xx@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox