Subject: Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

From: Jeff Kirsher <[email-masked]>
Date: Wed, 02 Dec 2015 01:56:55 -0800

On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
> Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string
> building")
> added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
> function i40e_print_features.
> 
> Fix it.
> 
> Miscellanea:
> 
> o Remove unnecessary string variable
> o Add space before not after fixed strings
> o Use kmalloc not kzalloc
> o Don't initialize i to 0, use result of first snprintf
> 
> Noticed-by: Sergei Shtylyov <[email-masked]>

Don't you mean Reported-by?  I am not aware of Noticed-by as being a
recognized signature.

> Signed-off-by: Joe Perches <[email-masked]>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +++++++++++++----
> ------------
>  1 file changed, 19 insertions(+), 23 deletions(-)