Subject: Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

From: "Charles (Chas) Williams" <[email-masked]>
Date: Thu, 03 Dec 2015 06:26:31 -0500

On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote:
> @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
>  	if (!str)
>  		return -EIO;
>  
> -	ver = simple_strtol(str, NULL, 10);
> -	if (ver < 1) {
> +	err = kstrtoint(str, 10, &ver);
> +	if (err || ver < 1) {
>  		dev_warn(&card->dev->dev, "Unexpected status interrupt version %d\n",
>  			 ver);
> -		return -EIO;
> +		return err;

If ver < 1 then you might return a 0 here.  Always returning -EIO is
probably just fine.