Subject: Re: Question regarding {G,S}CHANNELS API

From: Prashant Sreedharan <[email-masked]>
Date: Fri, 8 Jan 2016 10:17:13 -0800

On Fri, 2016-01-08 at 11:41 +0000, Jakub Kicinski wrote:

> The point of my email was that it's a bit cumbersome to express such
> configuration with the current ethtool API.  Therefore I'm asking if
> it's preferred to use:
>   ethtool ethX -L rx N tx M
For tg3 driver this is the preferred way

> in this case, or:
>   ethtool ethX -L combined N tx/rx abs(M-N)
tg3 will ignore the combined option and only consider separate tx / rx
values here. Combined will always be displayed as 0 to the user.

We understand your concern, and agree that the internal implementation
does not assign separate irq's to each tx, rx rings when tx/rx option is
used by user. With limited number of status blocks (max 4) and a HW bug
due to which not more than 1 TX ring is recommended to be enabled, it
was implemented in this manner.