From: Ben Hutchings <ben@decadent•org.uk>
To: Edward Cree <ecree@solarflare•com>,
Alexander Duyck <alexander.duyck@gmail•com>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: ethtool NFC/ntuple API questions
Date: Wed, 20 Jan 2016 19:22:51 +0000 [thread overview]
Message-ID: <1453317771.3734.68.camel@decadent.org.uk> (raw)
In-Reply-To: <569FDC04.9090509@solarflare.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Wed, 2016-01-20 at 19:12 +0000, Edward Cree wrote:
> Thanks both, it's making more sense now.
> One thing I'm still unclear about: why does struct ethtool_usrip4_spechave
> the ip_ver field? The struct can't be extended to cover ipv6, because the
> address fields aren't big enough. So what's it for?
It's also defined to always have the same value and mask! It's a
design bug.
> Also, would it be appropriate to use struct in6_addr for IPv6 addresses, or
> should I use __be32[4]?
I think for consistency with the IPv4 structures it should be __be32[4].
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-01-20 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:10 ethtool NFC/ntuple API questions Edward Cree
2016-01-20 17:53 ` Alexander Duyck
2016-01-20 18:07 ` Ben Hutchings
2016-01-20 19:12 ` Edward Cree
2016-01-20 19:22 ` Ben Hutchings [this message]
2016-01-21 19:14 ` [RFC PATCH] ethtool: add IPv6 to the NFC API Edward Cree
2016-01-21 22:48 ` Alexander Duyck
2016-01-22 17:03 ` Edward Cree
2016-01-22 18:04 ` [RFC PATCH v2] " Edward Cree
2016-01-22 18:54 ` Alexander Duyck
2016-01-25 3:34 ` Ben Hutchings
2016-01-25 3:20 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453317771.3734.68.camel@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=ecree@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox