From: Ben Hutchings <ben@decadent•org.uk>
To: Edward Cree <ecree@solarflare•com>, David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org,
linux-net-drivers <linux-net-drivers@solarflare•com>
Subject: Re: [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API
Date: Fri, 05 Feb 2016 01:32:52 +0000 [thread overview]
Message-ID: <1454635972.20702.8.camel@decadent.org.uk> (raw)
In-Reply-To: <56B0FA25.8030708@solarflare.com>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On Tue, 2016-02-02 at 18:49 +0000, Edward Cree wrote:
> Signed-off-by: Edward Cree <ecree@solarflare•com>
> ---
> include/uapi/linux/ethtool.h | 70 ++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 64 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> index 57fa390..3b6af3e 100644
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -748,6 +748,56 @@ struct ethtool_usrip4_spec {
> __u8 proto;
> };
>
> +/**
> + * struct ethtool_tcpip6_spec - flow specification for TCP/IPv6 etc.
> + * @ip6src: Source host
> + * @ip6dst: Destination host
> + * @psrc: Source port
> + * @pdst: Destination port
> + * @tos: Type-of-service
> + *
> + * This can be used to specify a TCP/IPv6, UDP/IPv6 or SCTP/IPv6 flow.
> + */
> +struct ethtool_tcpip6_spec {
> + __be32 ip6src[4];
> + __be32 ip6dst[4];
> + __be16 psrc;
> + __be16 pdst;
> + __u8 tos;
[...]
IPv6 has 'Traffic Class' instead of 'Type of Service'. At least the
kernel-doc comments should use the proper name, and perhaps you should
rename the 'tos' fields to something like 'tclass'. (Definitely not
just 'class' as UAPI headers have to be C++ compatible.)
Ben.
--
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert Einstein
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-02-05 1:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 18:47 [PATCH net-next 0/2] IPv6 NFC Edward Cree
2016-02-02 18:49 ` [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API Edward Cree
2016-02-05 1:32 ` Ben Hutchings [this message]
2016-02-02 18:49 ` [PATCH net-next 2/2] sfc: implement IPv6 NFC (and IPV4_USER_FLOW) Edward Cree
2016-02-05 1:47 ` Ben Hutchings
-- strict thread matches above, loose matches on Subject: below --
2016-02-05 11:12 [PATCH v2 net-next 0/2] IPv6 NFC Edward Cree
2016-02-05 11:16 ` [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API Edward Cree
2016-02-05 16:56 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454635972.20702.8.camel@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=ecree@solarflare$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox