From: "Keller, Jacob E" <jacob.e.keller@intel•com>
To: "moorray3@wp•pl" <moorray3@wp•pl>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time
Date: Mon, 8 Feb 2016 22:15:09 +0000 [thread overview]
Message-ID: <1454969709.25441.23.camel@intel.com> (raw)
In-Reply-To: <20160208205247.74aaaee8@jkicinski-Precision-T1700>
On Mon, 2016-02-08 at 20:52 +0000, Jakub Kicinski wrote:
> On Mon, 8 Feb 2016 12:06:04 -0800, Jacob Keller wrote:
> > + /* can't set combined and separate channels at the same
> > time */
> > + if ((channels.combined_count &&
> > + (channels.rx_count || channels.tx_count))
> > + return -EINVAL;
> > +
> > /* ensure the new Rx count fits within the configured Rx
> > flow
> > * indirection table settings */
> > if (netif_is_rxfh_configured(dev) &&
>
> My understanding is that unsymmetrical rx/tx queue configuration with
> combined IRQ vectors should be expressed as:
>
> combined = min(tx, rx);
> num_tx = tx - combined;
> num_rx = rx - combined;
>
> Please see:
>
> https://www.mail-archive.com/netdev@vger.kernel.org/msg93977.html
>
> Patches which I cooked up for this are rotting in my queue blocked by
> other things, unfortunately.
It looks like there was no follow up from your previous comment?
I think this looks right, in which case my patch should be dropped. I
do not think that .max_rx and .max_tx include the total for both Tx and
Rx maximums, though, so I am not sure best how to express the
possibility.
For now, I'll just drop this patch from the series.
Regards,
Jake
next prev parent reply other threads:[~2016-02-08 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 20:06 [PATCH 0/3] ethtool: correct {GS}CHANNELS and {GS}RXFH conflict Jacob Keller
2016-02-08 20:06 ` [PATCH 1/4] ethtool: correctly ensure {GS}CHANNELS doesn't conflict with GS{RXFH} Jacob Keller
2016-02-08 20:24 ` kbuild test robot
2016-02-08 20:31 ` kbuild test robot
2016-02-08 20:47 ` Jakub Kicinski
2016-02-08 20:06 ` [PATCH 2/4] ethtool: ensure channel counts are within bounds during SCHANNELS Jacob Keller
2016-02-08 20:29 ` kbuild test robot
2016-02-08 20:06 ` [PATCH 3/4] ethtool: can't set combined and tx/rx channel counts at the same time Jacob Keller
2016-02-08 20:25 ` kbuild test robot
2016-02-08 20:30 ` kbuild test robot
2016-02-08 20:52 ` Jakub Kicinski
2016-02-08 22:00 ` Keller, Jacob E
2016-02-08 22:15 ` Keller, Jacob E [this message]
2016-02-08 20:06 ` [PATCH 4/4] fm10k: don't reinitialize RSS flow table when RXFH configured Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454969709.25441.23.camel@intel.com \
--to=jacob.e.keller@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=moorray3@wp$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox