Subject: Re: [Intel-wired-lan] [next] igb: allow setting MAC address on i211 using a device tree blob V4

From: Jeff Kirsher <[email-masked]>
Date: Thu, 18 Feb 2016 01:15:01 -0800

On Thu, 2016-02-18 at 08:53 +0100, John Holland wrote:
> 
> > On Feb 18, 2016, at 03:29, David Miller <[email-masked]>
> wrote:
> > 
> > From: John Holland <[email-masked]>
> > Date: Thu, 18 Feb 2016 00:49:17 +0100
> > 
> >> The Intel i211 LOM pcie ethernet controllers' iNVM operates as an
> OTP
> >> and has no externel EEPROM interface [1]. The following allows the
> >> driver to pickup the MAC address from a device tree blob when
> >> CONFIG_OF
> >> has been enabled.
> > 
> > Please use the generic eth_platform_get_mac_address(), or
> > alternatively structure your code like the ixgbe and other cases so
> > that SPARC and other OF platforms get this support as well.
> 
> Don't know what you mean. The PCI path in
> eth_platform_get_mac_address() didn't return a devicetree node and I
> can find no instance of of_<function> use in ixgbe.

See commit e1be080f292eba2ef96af999057d1603cd50b473 in my dev-queue
branch.  Sowmini Varadhan provided a patch to
use eth_platform_get_mac_address() instead of the "CONFIG_SPARC"
solution.