From: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
To: David Miller <davem@davemloft•net>, gerlitz.or@gmail•com
Cc: gangfeng.huang@ni•com, netdev@vger•kernel.org,
nhorman@redhat•com, sassmann@redhat•com, jogreene@redhat•com
Subject: Re: [net-next 07/20] igb: add a character device to support AVB
Date: Wed, 24 Feb 2016 13:50:53 -0800 [thread overview]
Message-ID: <1456350653.2808.28.camel@intel.com> (raw)
In-Reply-To: <20160224.164520.2124246431953318783.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On Wed, 2016-02-24 at 16:45 -0500, David Miller wrote:
> From: Or Gerlitz <gerlitz.or@gmail•com>
> Date: Wed, 24 Feb 2016 22:06:25 +0200
>
> > On Wed, Feb 24, 2016 at 6:26 AM, Jeff Kirsher
> > <jeffrey.t.kirsher@intel•com> wrote:
> >> From: Gangfeng Huang <gangfeng.huang@ni•com>
> >
> >> This patch create a character device for Intel I210 Ethernet
> controller,
> >
> > wait, do we want L2 network driver to create char devices
> >
> >> it can be used for developing Audio/Video Bridging
> applications,Industrial
> >> Ethernet applications which require precise timing control over
> frame
> >> transmission, or test harnesses for measuring system latencies and
> sampling
> >> events.
> >
> > for various reasons such as the above?
>
> This is definitely not the direction to go for such a facility.
> Character devices make no sense at all, and are an invitation for
> ad-hoc user interfaces for what should be a generic and clean
> facility.
>
> There is no reason we cannot provide this facility with extensions
> of traditional networking APIs such as netlink or recvmsg/sendmsg
> over a raw or AF_PACKET socket.
>
> If there has been a lot of work, time and effort put into this
> character device solution then that's too bad. Because anything that
> ends up being user facing should have been proposed here on netdev
> from the start.
>
> I'm not applying this, no way.
Thanks Dave, I will drop this and the associated patches from the
series.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-24 21:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 4:26 [net-next 00/20][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-23 Jeff Kirsher
2016-02-24 4:26 ` [net-next 01/20] e1000e: Increase ULP timer Jeff Kirsher
2016-02-24 4:26 ` [net-next 02/20] e1000e: Increase PHY PLL clock gate timing Jeff Kirsher
2016-02-24 4:26 ` [net-next 03/20] e1000e: Set HW FIFO minimum pointer gap for non-gig speeds Jeff Kirsher
2016-02-24 4:26 ` [net-next 04/20] e1000e: Clear ULP configuration register on ULP exit Jeff Kirsher
2016-02-24 4:26 ` [net-next 05/20] e1000e: Initial support for KabeLake Jeff Kirsher
2016-02-24 4:26 ` [net-next 06/20] igb: add function to set I210 transmit mode Jeff Kirsher
2016-02-24 4:26 ` [net-next 07/20] igb: add a character device to support AVB Jeff Kirsher
2016-02-24 20:06 ` Or Gerlitz
2016-02-24 21:45 ` David Miller
2016-02-24 21:50 ` Jeff Kirsher [this message]
2016-02-24 4:26 ` [net-next 08/20] igb: fix compare_const_fl.cocci warnings Jeff Kirsher
2016-02-24 4:26 ` [net-next 09/20] igb: fix itnull.cocci warnings Jeff Kirsher
2016-02-24 4:26 ` [net-next 10/20] igb: fix semicolon.cocci warnings Jeff Kirsher
2016-02-24 4:26 ` [net-next 11/20] igb: When GbE link up, wait for Remote receiver status condition Jeff Kirsher
2016-02-24 4:26 ` [net-next 12/20] igb: constify e1000_phy_operations structure Jeff Kirsher
2016-02-24 4:26 ` [net-next 13/20] igb: enable WoL for OEM devices regardless of EEPROM setting Jeff Kirsher
2016-02-24 4:26 ` [net-next 14/20] igb: add conditions for I210 to generate periodic clock output Jeff Kirsher
2016-02-24 4:26 ` [net-next 15/20] igb: rename igb define to be more generic Jeff Kirsher
2016-02-24 4:26 ` [net-next 16/20] igb: Add support for generic Tx checksums Jeff Kirsher
2016-02-24 4:26 ` [net-next 17/20] igbvf: " Jeff Kirsher
2016-02-24 4:26 ` [net-next 18/20] igbvf: remove "link is Up" message when registering mcast address Jeff Kirsher
2016-02-24 4:26 ` [net-next 19/20] igb: Fix VLAN tag stripping on Intel i350 Jeff Kirsher
2016-02-24 4:26 ` [net-next 20/20] igb: call ndo_stop() instead of dev_close() when running offline selftest Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456350653.2808.28.camel@intel.com \
--to=jeffrey.t.kirsher@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gangfeng.huang@ni$(echo .)com \
--cc=gerlitz.or@gmail$(echo .)com \
--cc=jogreene@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox