Subject: Re: [ethtool PATCH v2 10/12] internal.h: TRUE/FALSE macros

From: Joe Perches <[email-masked]>
Date: Thu, 03 Mar 2016 20:35:16 -0800

On Thu, 2016-03-03 at 20:23 -0800, David Decotigny wrote:
> From: David Decotigny <[email-masked]>
[]
> diff --git a/internal.h b/internal.h
[]
> @@ -42,6 +42,14 @@ typedef int32_t s32;
>  #include "ethtool-copy.h"
>  #include "net_tstamp-copy.h"
>  
> +#ifndef TRUE
> +#  define TRUE (!0)
> +#endif
> +
> +#ifndef FALSE
> +#  define FALSE (!!0)

#define TRUE 1
and
#define FALSE 0
are obvious and typical.

The ! and !! uses don't add anything other than obscurity.