From: Johannes Berg <johannes@sipsolutions•net>
To: Stephen Hemminger <shemming@brocade•com>, Phil Sutter <phil@nwl•cc>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [iproute PATCH] libnetlink: Double the dump buffer size
Date: Sat, 05 Mar 2016 22:12:16 +0100 [thread overview]
Message-ID: <1457212336.3032.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20160304153553.47e8741d@xeon-e3> (sfid-20160305_003554_298078_24E675A8)
On Fri, 2016-03-04 at 15:35 -0800, Stephen Hemminger wrote:
>
> > There have been reports about 'ip addr' printing "Message
> > truncated" on
[...]
> I thought this was addressed in kernel by making the VF info
> optional.
> The netlink protocol is showing some strain, this is one of them.
I don't know how the dump is split here, but we had a similar issue
with nl80211 - originally each physical device info had to fit into a
single message (one message during dump for each device), but we fixed
that by having userspace to set a flag when it's able to understand a
multi-message single physical device info.
Before:
msg1: phy1: A, B, C
msg2: phy2: A, B, C
After:
msg1: phy1: A
msg2: phy1: B
msg3: phy1: C
msg4: phy1: D
msg5: phy2: A
[...]
For userspace not setting the flag, it only get partial info today for
compatibility (A, B, C, not D), but in our particular case this was
perfectly reasonable since it would be unaware of the new capabilities
anyway.
I don't know precisely enough what the issue at hand is to comment
whether such an approach will be feasible here, but it seems it could
be.
johannes
next prev parent reply other threads:[~2016-03-05 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8e235f49b8314d70bbf76709a81c4d84@HQ1WP-EXMB11.corp.brocade.com>
2016-03-04 23:35 ` [iproute PATCH] libnetlink: Double the dump buffer size Stephen Hemminger
2016-03-05 0:57 ` Phil Sutter
2016-03-05 21:12 ` Johannes Berg [this message]
[not found] ` <20160305005746.GS28939@base.sg13b.nwl.cc>
2016-03-08 13:28 ` Phil Sutter
2016-03-04 18:57 Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457212336.3032.3.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phil@nwl$(echo .)cc \
--cc=shemming@brocade$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox