public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions•net>
To: Ben Greear <greearb@candelatech•com>, David Miller <davem@davemloft•net>
Cc: linux-kernel@vger•kernel.org, herbert@gondor•apana.org.au,
	linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
	tgraf@suug•ch
Subject: Re: Question on rhashtable in worst-case scenario.
Date: Thu, 31 Mar 2016 17:22:41 +0200	[thread overview]
Message-ID: <1459437761.4576.25.camel@sipsolutions.net> (raw)
In-Reply-To: <56FD3E91.9020804@candelatech.com>

On Thu, 2016-03-31 at 08:13 -0700, Ben Greear wrote:
> 
> I see insertion failure, and then later, if of course fails to delete
> as well since it was never inserted to begin with.  There is no good
> way to deal with insertion error, so just need to fix the hashtable.

Oh, that's an oversight in mac80211 - it should be dealing with
insertion failures properly. This isn't really a problem either,
although it will lead to errors in your particular case.

https://p.sipsolutions.net/cf77c78d69a231d4.txt

johannes

      reply	other threads:[~2016-03-31 15:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <56F9941A.3080501@candelatech.com>
     [not found] ` <56FAAA6D.3070806@candelatech.com>
2016-03-30  9:14   ` Question on rhashtable in worst-case scenario Johannes Berg
     [not found]     ` <1459329252.2055.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-03-30 13:55       ` Herbert Xu
2016-03-30 14:03         ` Johannes Berg
2016-03-30 14:09           ` Herbert Xu
2016-03-30 16:38     ` David Miller
2016-03-30 16:52       ` Ben Greear
2016-03-31  7:46         ` Johannes Berg
2016-03-31  7:50           ` Herbert Xu
2016-03-31 15:29             ` Johannes Berg
2016-04-01  0:46               ` Herbert Xu
2016-04-01 18:17                 ` Ben Greear
2016-04-01 21:34                 ` Johannes Berg
2016-04-02  1:46                   ` Herbert Xu
2016-04-02 18:33                     ` Johannes Berg
2016-03-31 15:13           ` Ben Greear
2016-03-31 15:22             ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459437761.4576.25.camel@sipsolutions.net \
    --to=johannes@sipsolutions$(echo .)net \
    --cc=davem@davemloft$(echo .)net \
    --cc=greearb@candelatech$(echo .)com \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-wireless@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=tgraf@suug$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox