From: Johannes Berg <johannes@sipsolutions•net>
To: Petko Manolov <petkan@mip-labs•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, a1291762@gmail•com
Subject: Re: [PATCH v2 0/2] pegasus: correct buffer sizes
Date: Wed, 27 Apr 2016 09:46:15 +0200 [thread overview]
Message-ID: <1461743175.3723.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1461742525-2748-1-git-send-email-petkan@mip-labs.com> (sfid-20160427_093549_878302_3DDEE29D)
On Wed, 2016-04-27 at 10:35 +0300, Petko Manolov wrote:
>
> Nearly all Pegasus devices may append the RX status to the end of the
> received packet. It is the default setup for the driver. The
> actual ethernet packet is 4 bytes shorter. Why and when 'pkt_len -=
> 4' became 'pkt_len -= 8' is again hidden in the mists of time. There
> might have been a good reason to do so, but multiple reads of the
> datasheet did not point me to any.
>
Wild guess: (some) devices pass the FCS, perhaps depending on the
configuration?
johannes
next prev parent reply other threads:[~2016-04-27 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 7:35 [PATCH v2 0/2] pegasus: correct buffer sizes Petko Manolov
2016-04-27 7:35 ` [PATCH v2 1/2] pegasus: fixes URB buffer allocation size; Petko Manolov
2016-04-27 7:35 ` [PATCH v2 2/2] pegasus: fixes reported packet length Petko Manolov
2016-04-27 7:46 ` Johannes Berg [this message]
[not found] ` <20160427093358.GA30444@p310>
2016-04-27 9:44 ` [PATCH v2 0/2] pegasus: correct buffer sizes Johannes Berg
2016-04-27 16:26 ` David Laight
2016-04-28 6:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461743175.3723.1.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=a1291762@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petkan@mip-labs$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox