From: Ben Hutchings <ben@decadent•org.uk>
To: Philippe Reynes <tremyfr@gmail•com>,
f.fainelli@gmail•com, fugang.duan@nxp•com, davem@davemloft•net
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings
Date: Sat, 07 May 2016 12:59:57 +0100 [thread overview]
Message-ID: <1462622397.19332.28.camel@decadent.org.uk> (raw)
In-Reply-To: <1462576729-5932-1-git-send-email-tremyfr@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
>
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.
[...]
I don't think there's no need to access a private structure, as there's
a phydev pointer in struct net_device. If some drivers don't maintain
that pointer, they should be changed to do so. Then they can
use generic implementations of {get,set}_link_ksettings provided by
phylib.
Ben.
--
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-07 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 23:18 [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Philippe Reynes
2016-05-06 23:18 ` [PATCH 2/2] net: ethernet: fec: use ethtool_phy_{get|set}_link_ksettings Philippe Reynes
2016-05-06 23:41 ` [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings Florian Fainelli
2016-05-07 11:59 ` Ben Hutchings [this message]
2016-05-07 22:56 ` Philippe Reynes
2016-05-08 0:13 ` Ben Hutchings
2016-05-08 18:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462622397.19332.28.camel@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fugang.duan@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tremyfr@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox