From: Martin Willi <martin-jzJueiEJWxp8fCCB1iTX4w@public•gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces
Date: Mon, 09 May 2016 18:33:05 +0200 [thread overview]
Message-ID: <1462811585.18382.22.camel@strongswan.org> (raw)
In-Reply-To: <1462779045.30690.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> > Moving the radio back to the creators namespace would be the most
> > consistent behavior, so I'll check how difficult such a reverse
> > lookup is. We then would delete the radio only if it is in the
> > creators namespace, or if the creators namespace is gone. Does that
> > make sense?
> It does make sense, but it does also feel a bit complicated.
Yes, and proper locking gets difficult when using cfg80211_set_netns(),
which can sleep. This would probably need larger changes in the locking
code, but that's IMO not worth the effort.
> Perhaps just special-case the init_net case for consistency with the
> existing behaviour, and reserve netgroup 0 for that so we can easily
> check for it?
I'll do that in a v2, following immediately.
> > I suspect you should be defining a structure that currently
> > contains one integer member. Something (maybe a compile time
> > assert) needs to check that buffer space you are accessing (where
> > ever it is) is large enough.
>
> It does look a bit awkward, but there's no value in having a struct -
> you still have an opaque pointer here and cast it to something whose
> size you assume to be present... it really makes no difference.
I agree there is no added safety when using a struct; Nonetheless have
I added one in v2, and is it just for any future member additions.
Best regards
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-09 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 6:53 [PATCH 0/2] wireless: Allow wiphy/hwsim management from user namespaces Martin Willi
2016-05-03 6:53 ` [PATCH 1/2] nl80211: Allow privileged operations " Martin Willi
2016-05-03 6:53 ` [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces Martin Willi
2016-05-03 6:56 ` Johannes Berg
[not found] ` <1462258398-6749-3-git-send-email-martin-jzJueiEJWxp8fCCB1iTX4w@public.gmane.org>
2016-05-03 19:16 ` Johannes Berg
[not found] ` <1462302992.10444.11.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-05-04 8:33 ` Martin Willi
2016-05-09 7:30 ` Johannes Berg
[not found] ` <1462779045.30690.2.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-05-09 16:33 ` Martin Willi [this message]
2016-05-05 10:16 ` David Laight
[not found] ` <063D6719AE5E284EB5DD2968C1650D6D5F4B5302-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2016-05-09 7:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462811585.18382.22.camel@strongswan.org \
--to=martin-jzjueiejwxp8fccb1itx4w@public$(echo .)gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox