Subject: Re: [PATCH 3/3] mac80211: mesh: Add support for HW RC implementation

From: Johannes Berg <[email-masked]>
Date: Tue, 21 Jun 2016 11:18:19 +0200

> -	if (sta->mesh->fail_avg >= 100)
> -		return MAX_METRIC;
> +	/* try to get rate based on HW RC algorithm */
> +	rate = drv_get_expected_throughput(local, &sta->sta);

This doesn't look correct, since you should use the rate control op if
available, to get data from rate control algorithms.

You should call sta_set_sinfo(), but that's far too much, so more
likely you should factor out the last few lines of that into a new
function and call that new function in both places.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html