From: Paolo Abeni <pabeni@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: jiri@resnulli•us, netdev@vger•kernel.org, jiri@mellanox•com,
aduyck@mirantis•com, edumazet@google•com, daniel@iogearbox•net
Subject: Re: [PATCH net] net: avoid vlan ptype specific match to be leaked on real device
Date: Mon, 27 Jun 2016 11:28:32 +0200 [thread overview]
Message-ID: <1467019712.4606.7.camel@redhat.com> (raw)
In-Reply-To: <20160626.160608.2073563033978522175.davem@davemloft.net>
On Sun, 2016-06-26 at 16:06 -0400, David Miller wrote:
> From: Jiri Pirko <jiri@resnulli•us>
> Date: Wed, 22 Jun 2016 14:40:50 +0200
>
> > The patch only unified the behaviour so everyone know what to expect
> > regardless of the device type.
>
> +1
>
> And reverting this behavior back is going to hurt more people than it
> will help, so I am not going to apply this, sorry.
Would a /proc/net/vlan sysctl to control the switch from the new to the
old behavior (with default to the new) make this acceptable ?
Recent users will not be affected, and users of the old behavior could
manage kernel upgrade without breaking their applications.
Thank you,
Paolo
next prev parent reply other threads:[~2016-06-27 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 10:25 [PATCH net] net: avoid vlan ptype specific match to be leaked on real device Paolo Abeni
2016-06-22 10:55 ` Jiri Pirko
2016-06-22 12:21 ` Paolo Abeni
2016-06-22 12:40 ` Jiri Pirko
2016-06-26 20:06 ` David Miller
2016-06-27 9:28 ` Paolo Abeni [this message]
2016-06-27 9:37 ` Jiri Pirko
2016-06-27 13:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467019712.4606.7.camel@redhat.com \
--to=pabeni@redhat$(echo .)com \
--cc=aduyck@mirantis$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox