From: Joe Perches <joe@perches•com>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Yisen Zhuang <Yisen.Zhuang@huawei•com>,
davem@davemloft•net, salil.mehta@huawei•com,
yankejian@huawei•com
Cc: liguozhu@huawei•com, huangdaode@hisilicon•com, arnd@arndb•de,
andrew@lunn•ch, geliangtang@163•com, ivecera@redhat•com,
fengguang.wu@intel•com, charles.chenxin@huawei•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linuxarm@huawei•com
Subject: Re: [PATCH net-next 6/9] net: hns: normalize two different loop
Date: Mon, 27 Jun 2016 05:08:58 -0700 [thread overview]
Message-ID: <1467029338.1847.106.camel@perches.com> (raw)
In-Reply-To: <1467028835.30123.287.camel@linux.intel.com>
On Mon, 2016-06-27 at 15:00 +0300, Andy Shevchenko wrote:
> On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote:
> >
> > On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote:
> > >
> > > From: Daode Huang <huangdaode@hisilicon•com>
> > >
> > > There are two approaches to assign data, one does 2 loops, another
> > > does 1 loop. This patch normalize the different methods to 1 loop.
> > []
> > >
> > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
> > > b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
> > []
> > >
> > > @@ -2567,15 +2567,15 @@ static char
> > > *hns_dsaf_get_node_stats_strings(char *data, int node,
> > > buff += ETH_GSTRING_LEN;
> > > if (node < DSAF_SERVICE_NW_NUM && !is_ver1) {
> > > for (i = 0; i < DSAF_PRIO_NR; i++) {
> > > - snprintf(buff, ETH_GSTRING_LEN,
> > > - "inod%d_pfc_prio%d_pkts", node,
> > > i);
> > > - buff += ETH_GSTRING_LEN;
> > > - }
> > > - for (i = 0; i < DSAF_PRIO_NR; i++) {
> > > - snprintf(buff, ETH_GSTRING_LEN,
> > > - "onod%d_pfc_prio%d_pkts", node,
> > > i);
> > > + snprintf(buff + 0 * ETH_GSTRING_LEN *
> > > DSAF_PRIO_NR,
> > > + ETH_GSTRING_LEN,
> > > "inod%d_pfc_prio%d_pkts",
> > > + node, i);
> > > + snprintf(buff + 1 * ETH_GSTRING_LEN *
> > > DSAF_PRIO_NR,
> > > + ETH_GSTRING_LEN,
> > > "onod%d_pfc_prio%d_pkts",
> > > + node, i);
> > > buff += ETH_GSTRING_LEN;
> > This looks odd and likely incorrect.
> Why? the idea is to print stats for Rx and Tx at once.
>
> I hope it was tested.
It changes the order of the strings in buff.
Is a bug fix or a style fix?
If it's a bug fix, then it should likely be added
to the stable trees.
next prev parent reply other threads:[~2016-06-27 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 9:54 [PATCH net-next 0/9] net: hns: fix the typo of hns Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 1/9] MAINTAINERS: add maintainers for hns driver Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 2/9] net: hns: fix code style about " Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 3/9] net: hns: change code style from a = a + x to a += x Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 4/9] net: hns: delete redundant parens Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 5/9] net: hns: add a space before "*/" Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 6/9] net: hns: normalize two different loop Yisen Zhuang
2016-06-27 11:49 ` Joe Perches
2016-06-27 12:00 ` Andy Shevchenko
2016-06-27 12:08 ` Joe Perches [this message]
2016-06-27 12:13 ` Andy Shevchenko
2016-06-28 5:41 ` Daode Huang
2016-06-27 9:54 ` [PATCH net-next 7/9] net: hns: remove redundant hns_mac_dev_to_enet_if() Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 8/9] net: hns: add media-type property for hns Yisen Zhuang
2016-06-27 9:54 ` [PATCH net-next 9/9] net: hns: get reset registers from DT Yisen Zhuang
2016-06-29 9:11 ` David Miller
2016-06-30 1:10 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467029338.1847.106.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=Yisen.Zhuang@huawei$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=charles.chenxin@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fengguang.wu@intel$(echo .)com \
--cc=geliangtang@163$(echo .)com \
--cc=huangdaode@hisilicon$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=liguozhu@huawei$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=salil.mehta@huawei$(echo .)com \
--cc=yankejian@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox