Subject: Re: [net-next 14/14] ixgbe: cleanup crosstalk fix

From: Joe Perches <[email-masked]>
Date: Sat, 23 Jul 2016 10:38:59 -0700

On Fri, 2016-07-22 at 23:49 -0700, Jeff Kirsher wrote:
> From: Don Skidmore <[email-masked]>
> 
> This patch address a few issues with the initial crosstalk fix.  Most
> important of which is the SDP that indicates the presents of a SFP+
> module changes between HW types.  With this change that is taken in
> to consideration
[]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
[]
> @@ -301,6 +302,22 @@ s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw)
>  	if (ret_val)
>  		return ret_val;
>  
> +	/* Cashe bit indicating need for crosstalk fix */

spello: cache

> +	switch (hw->mac.type) {
> +	case ixgbe_mac_82599EB:
> +	case ixgbe_mac_X550EM_x:
> +	case ixgbe_mac_x550em_a:
> +		hw->mac.ops.get_device_caps(hw, &device_caps);
> +		if (device_caps & IXGBE_DEVICE_CAPS_NO_CROSSTALK_WR)
> +			hw->need_crosstalk_fix = false;
> +		else
> +			hw->need_crosstalk_fix = true;

could be
		hw->need_crosstalk_fix = !(device_caps & IXGBE_DEVICE_CAPS_NO_CROSSTALK_WR);