From: Joe Perches <joe@perches•com>
To: Raghu Vatsavayi <rvatsavayi@caviumnetworks•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org,
Derek Chickles <derek.chickles@caviumnetworks•com>,
Satanand Burla <satananda.burla@caviumnetworks•com>,
Felix Manlunas <felix.manlunas@caviumnetworks•com>,
Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks•com>
Subject: Re: [PATCH net-next V2 01/18] liquidio: Consolidate common functionality
Date: Fri, 12 Aug 2016 12:21:09 -0700 [thread overview]
Message-ID: <1471029669.18251.6.camel@perches.com> (raw)
In-Reply-To: <1471026035-15323-2-git-send-email-rvatsavayi@caviumnetworks.com>
On Fri, 2016-08-12 at 11:20 -0700, Raghu Vatsavayi wrote:
> Consolidate common functionality of various devices
> from different files into lio_core.c/octeon_console.c.
trivial notes:
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
[]
> +void liquidio_link_ctrl_cmd_completion(void *nctrl_ptr)
> +{
[]
> + case OCTNET_CMD_CHANGE_MACADDR:
> + mac = ((u8 *)&nctrl->udd[0]) + 2;
> + netif_info(lio, probe, lio->netdev,
> + "MACAddr changed to %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n",
"MACAddr changed to %pM\n", mac);
[]
> + case OCTNET_CMD_TNL_RX_CSUM_CTL:
> + if (nctrl->ncmd.s.param1 == OCTNET_CMD_RXCSUM_ENABLE) {
> + netif_info(lio, probe, lio->netdev,
> + "%s RX Checksum Offload Enabled\n",
> + netdev->name);
> + } else if (nctrl->ncmd.s.param1 ==
> + OCTNET_CMD_RXCSUM_DISABLE) {
> + netif_info(lio, probe, lio->netdev,
> + "%s RX Checksum Offload Disabled\n",
> + netdev->name);
Aren't these a bit redundant output with the both name
output of lio->netdev->name and netdev->name?
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c
[]
> @@ -297,11 +297,10 @@ lio_get_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom,
>
> eeprom->magic = oct_dev->pci_dev->vendor;
> board_info = (struct octeon_board_info *)(&oct_dev->boardinfo);
> - len =
> - sprintf((char *)bytes,
> - "boardname:%s serialnum:%s maj:%lld min:%lld\n",
> - board_info->name, board_info->serial_number,
> - board_info->major, board_info->minor);
> + len = sprintf((char *)bytes,
> + "boardname:%s serialnum:%s maj:%lld min:%lld\n",
> + board_info->name, board_info->serial_number,
> + board_info->major, board_info->minor);
snprintf might be better and len doesn't seem useful here
> return 0;
> }
next prev parent reply other threads:[~2016-08-12 19:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 18:20 [PATCH net-next V2 00/18] liquidio CN23XX support Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 01/18] liquidio: Consolidate common functionality Raghu Vatsavayi
2016-08-12 19:21 ` Joe Perches [this message]
2016-08-12 18:20 ` [PATCH net-next V2 02/18] liquidio: Firmware version management Raghu Vatsavayi
2016-08-12 19:24 ` Joe Perches
2016-08-12 18:20 ` [PATCH net-next V2 03/18] liquidio: Common enable irq function Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 04/18] liquidio: CN23XX register definitions Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 05/18] liquidio: CN23XX queue definitions Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 06/18] liquidio: CN23XX device init and sriov config Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 07/18] liquidio: CN23XX register setup Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 08/18] liquidio: CN23XX queue manipulation Raghu Vatsavayi
2016-08-12 19:30 ` Joe Perches
2016-08-12 18:20 ` [PATCH net-next V2 09/18] liquidio: MSIX support for CN23XX Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 10/18] liquidio: CN23XX firmware download Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 11/18] liquidio: link and control commands Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 12/18] liquidio: RX " Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 13/18] liquidio: CN23XX IQ access Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 14/18] liquidio: CN23XX octeon3 instruction Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 15/18] liquidio: ethtool and led control support Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 16/18] liquidio: CN23XX health monitoring Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 17/18] liquidio: CN23XX napi support Raghu Vatsavayi
2016-08-12 18:20 ` [PATCH net-next V2 18/18] liquidio:CN23XX pause frame support Raghu Vatsavayi
2016-08-13 18:59 ` [PATCH net-next V2 00/18] liquidio CN23XX support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471029669.18251.6.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=derek.chickles@caviumnetworks$(echo .)com \
--cc=felix.manlunas@caviumnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=raghu.vatsavayi@caviumnetworks$(echo .)com \
--cc=rvatsavayi@caviumnetworks$(echo .)com \
--cc=satananda.burla@caviumnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox