From: Paolo Abeni <pabeni@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Tom Herbert <tom@herbertland•com>,
Hannes Frederic Sowa <hannes@stressinduktion•org>
Subject: Re: [PATCH net-next] net: flush the softnet backlog in process context
Date: Thu, 25 Aug 2016 16:58:38 +0200 [thread overview]
Message-ID: <1472137118.4769.38.camel@redhat.com> (raw)
In-Reply-To: <1472136456.14381.133.camel@edumazet-glaptop3.roam.corp.google.com>
On Thu, 2016-08-25 at 07:47 -0700, Eric Dumazet wrote:
> On Thu, 2016-08-25 at 07:32 -0700, Eric Dumazet wrote:
>
> > In a future patch, we could change this so that we kick
> > flush_all_backlogs() once for all devices, instead of one device at a
> > time.
> >
> > We would not pass @dev anymore as a parameter and simply look at
> > skb->dev->reg_state to decide to remove packets from queues in
> > flush_backlog()
>
> This would be something like :
This is actually a nice cleanup. I hope to test it later.
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 7feae74ca928..793ace2c600f 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -4293,7 +4293,6 @@ int netif_receive_skb(struct sk_buff *skb)
> EXPORT_SYMBOL(netif_receive_skb);
>
> struct flush_work {
> - struct net_device *dev;
> struct work_struct work;
> };
With 'dev' removal, I think we can use directly 'work_struct' and avoid
'container_of' usage in flush_backlog().
Paolo
next prev parent reply other threads:[~2016-08-25 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 13:58 [PATCH net-next] net: flush the softnet backlog in process context Paolo Abeni
2016-08-25 14:32 ` Eric Dumazet
2016-08-25 14:47 ` Eric Dumazet
2016-08-25 14:58 ` Paolo Abeni [this message]
2016-08-25 16:25 ` Eric Dumazet
2016-08-26 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472137118.4769.38.camel@redhat.com \
--to=pabeni@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox