From: Joe Perches <joe@perches•com>
To: Greg Rose <gvrose8192@gmail•com>, netdev@vger•kernel.org
Cc: Greg Rose <grose@lightfleet•com>
Subject: Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy
Date: Wed, 31 Aug 2016 09:41:25 -0700 [thread overview]
Message-ID: <1472661685.4176.10.camel@perches.com> (raw)
In-Reply-To: <1472661168-22396-1-git-send-email-grose@lightfleet.com>
On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote:
> I'm not sure why this hasn't been done before because it seems obvious,
> so maybe there is some reason that memcpy is used instead of
> ether_addr_copy in this code. But let's try this anyway.
>
> Change memcpy to ether_addr_copy.
I looked at this once and gave up given the need to verify all
the possible callers that require an __aligned(2) source address.
next prev parent reply other threads:[~2016-08-31 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 16:32 [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy Greg Rose
2016-08-31 16:41 ` Joe Perches [this message]
2016-08-31 16:42 ` Greg
2016-08-31 18:32 ` Eric Dumazet
2016-08-31 18:34 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472661685.4176.10.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=grose@lightfleet$(echo .)com \
--cc=gvrose8192@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox