Subject: Re: [PATCH net-next 2/3] smsc95xx: Add register define

From: Joe Perches <[email-masked]>
Date: Fri, 02 Sep 2016 13:40:01 -0700

On Fri, 2016-09-02 at 20:34 +0000, [email-masked] wrote:
> From: Woojung Huh <[email-masked]>
> 
> Add STRAP_STATUS defines.
[]
> diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h
[]
> @@ -144,6 +144,14 @@
>  
>  #define BURST_CAP			(0x38)
>  
> +#define	STRAP_STATUS			(0x3C)
> +#define	STRAP_STATUS_PWR_SEL_		(0x00000020)
> +#define	STRAP_STATUS_AMDIX_EN_		(0x00000010)
> +#define	STRAP_STATUS_PORT_SWAP_		(0x00000008)
> +#define	STRAP_STATUS_EEP_SIZE_		(0x00000004)
> +#define	STRAP_STATUS_RMT_WKP_		(0x00000002)
> +#define	STRAP_STATUS_EEP_DISABLE_	(0x00000001)

Using BIT would be more common.

Ending the #defines with an underscore is just odd
and unappealing.