public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Patrick Ruddy <pruddy@Brocade•com>
To: "roopa@cumulusnetworks•com" <roopa@cumulusnetworks•com>
Cc: "stephen@networkplumber•org" <stephen@networkplumber•org>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"davem@davemloft•net" <davem@davemloft•net>,
	Luca Boccassi <lboccass@Brocade•com>,
	"alexander.h.duyck@intel•com" <alexander.h.duyck@intel•com>,
	"jiri@resnulli•us" <jiri@resnulli•us>,
	Sven-Thorsten Dietrich <sven@brocade•com>
Subject: Re: [net-next PATCH] net: netlink messages for HW addr programming
Date: Mon, 19 Sep 2016 14:46:19 +0000	[thread overview]
Message-ID: <1474296378.31262.59.camel@brocade.com> (raw)
In-Reply-To: <57DEA9E2.3000703@cumulusnetworks.com>

On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote:
> On 9/15/16, 9:48 AM, Patrick Ruddy wrote:
> > Add RTM_NEWADDR and RTM_DELADDR netlink messages with family
> > AF_UNSPEC to indicate interest in specific unicast and multicast
> > hardware addresses. These messages are sent when addresses are
> > added or deleted from the appropriate interface driver.
> > Added AF_UNSPEC GETADDR function to allow the netlink notifications
> > to be replayed to avoid loss of state due to application start
> > ordering or restart.
> >
> > Signed-off-by: Patrick Ruddy <pruddy@brocade•com>
> > ---
> 
> RTM_NEWADDR and RTM_DELADDR are not used to add these entries to the kernel.
> so, it seems a bit wrong to use RTM_NEWADDR and RTM_DELADDR to notify them to
> userspace and also to request a special dump of these addresses.
> 
> This could just be a new nested netlink attribute in the existing link dump ?

Hi Roopa

Thanks for the review. I did initially code this using NEW/DEL/GET_LINK
messages but was asked to change to to ADDR messages by Stephen
Hemminger (cc'd). 

However I agree that these addresses fall between the LINK and ADDR
areas so I'm happy to change this if we can reach some consensus on the
format.

thanks

-pr

next prev parent reply	other threads:[~2016-09-19 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 16:48 [net-next PATCH] net: netlink messages for HW addr programming Patrick Ruddy
2016-09-18 14:51 ` Roopa Prabhu
2016-09-19 14:46   ` Patrick Ruddy [this message]
2016-09-20  5:31     ` Roopa Prabhu
2016-09-20  5:49       ` Jiri Pirko
2016-09-20  6:36         ` Roopa Prabhu
2016-10-03 10:42         ` Patrick Ruddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474296378.31262.59.camel@brocade.com \
    --to=pruddy@brocade$(echo .)com \
    --cc=alexander.h.duyck@intel$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=jiri@resnulli$(echo .)us \
    --cc=lboccass@Brocade$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=roopa@cumulusnetworks$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    --cc=sven@brocade$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox