From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>
To: Johannes Thumshirn <jthumshirn-l3A5Bk7waGM@public•gmane.org>,
Solomon Peachy <pizza-pCgMCH4qpMRg9hUCZPvPmw@public•gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Date: Fri, 30 Sep 2016 14:29:39 +0200 [thread overview]
Message-ID: <1475238579.17481.56.camel@sipsolutions.net> (raw)
In-Reply-To: <1475237495-15030-1-git-send-email-jthumshirn-l3A5Bk7waGM@public.gmane.org> (sfid-20160930_141208_240938_8F56ACB3)
> + tmp = krealloc(buf->begin, size, GFP_KERNEL | GFP_DMA);
> + if (tmp) {
>
I think that check is inverted?
johannes
next prev parent reply other threads:[~2016-09-30 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 12:11 [PATCH 1/3] cw1200: Don't leak memory if krealloc failes Johannes Thumshirn
[not found] ` <1475237495-15030-1-git-send-email-jthumshirn-l3A5Bk7waGM@public.gmane.org>
2016-09-30 12:29 ` Johannes Berg [this message]
2016-09-30 12:33 ` Johannes Thumshirn
2016-09-30 12:56 ` Sergei Shtylyov
[not found] ` <25a38254-f0e3-1f4e-de46-688d9fd1b736-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-09-30 13:00 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475238579.17481.56.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public$(echo .)gmane.org \
--cc=jthumshirn-l3A5Bk7waGM@public$(echo .)gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=pizza-pCgMCH4qpMRg9hUCZPvPmw@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox