Subject: Re: [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP interfaces

From: Johannes Berg <[email-masked]>
Date: Mon, 10 Oct 2016 12:28:33 +0200

>   *
> + * @NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED: Multicast packets
> should be
> + *      send out as unicast to all stations.

You should document what type of attribute is expected. You probably
wanted a flag attribute, but ...

> +	[NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED] = { .type =
> NLA_U8, },

have u8 in the policy, yet

> +	enabled = nla_get_flag(nla);

actually use as a flag :)

In addition to that, I think you should clarify the "per-BSS" comment
in nl80211, and also clarify (at the same place) what kind of
functionality is expected from this.

johannes