From: Timur Tabi <timur@codeaurora•org>
To: netdev@vger•kernel.org, zefir.kurtisi@neratec•com,
scampbel@codeaurora•org, alokc@codeaurora•org,
shankerd@codeaurora•org, andrew@lunn•ch, f.fainelli@gmail•com
Subject: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames
Date: Thu, 27 Oct 2016 17:05:01 -0500 [thread overview]
Message-ID: <1477605901-30906-1-git-send-email-timur@codeaurora.org> (raw)
The Atheros 8031 PHY supports the 802.3 extension for symmetric and
asymmetric pause frames, so set that to the list of features supported
by the phy.
Signed-off-by: Timur Tabi <timur@codeaurora•org>
---
Without this patch, my NIC (the Qualcomm EMAC) receives a lot of frame
check sequence (aka CRC) errors, resulting in about 10% packet loss.
Can someone help me understand why? Because of this patch, I can't use
the generic phy driver in phylib. Why would a MAC controller require
its PHY to support pause frames?
drivers/net/phy/at803x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index a52b560..fb80413 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -440,7 +440,8 @@ static struct phy_driver at803x_driver[] = {
.get_wol = at803x_get_wol,
.suspend = at803x_suspend,
.resume = at803x_resume,
- .features = PHY_GBIT_FEATURES,
+ .features = PHY_GBIT_FEATURES |
+ SUPPORTED_Pause | SUPPORTED_Asym_Pause,
.flags = PHY_HAS_INTERRUPT,
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next reply other threads:[~2016-10-27 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 22:05 Timur Tabi [this message]
2016-10-27 22:12 ` [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames Florian Fainelli
2016-10-27 22:24 ` Timur Tabi
2016-10-27 22:39 ` Florian Fainelli
2016-10-28 20:06 ` Timur Tabi
2016-10-28 21:03 ` Florian Fainelli
2016-10-31 17:23 ` Timur Tabi
2016-10-31 17:55 ` Florian Fainelli
2016-10-31 21:14 ` Timur Tabi
2016-10-31 17:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477605901-30906-1-git-send-email-timur@codeaurora.org \
--to=timur@codeaurora$(echo .)org \
--cc=alokc@codeaurora$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scampbel@codeaurora$(echo .)org \
--cc=shankerd@codeaurora$(echo .)org \
--cc=zefir.kurtisi@neratec$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox