From: Timur Tabi <timur@codeaurora•org>
To: David Miller <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>,
netdev@vger•kernel.org
Subject: [PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames
Date: Tue, 1 Nov 2016 13:30:54 -0500 [thread overview]
Message-ID: <1478025055-13167-1-git-send-email-timur@codeaurora.org> (raw)
Pause frames are used to enable flow control. A MAC can send and
receive pause frames in order to throttle traffic. However, the PHY
must be configured to allow those frames to pass through.
Signed-off-by: Timur Tabi <timur@codeaurora•org>
---
drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.c b/drivers/net/ethernet/qualcomm/emac/emac-mac.c
index 6fb3bee..70a55dc 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-mac.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.c
@@ -1003,6 +1003,12 @@ int emac_mac_up(struct emac_adapter *adpt)
writel((u32)~DIS_INT, adpt->base + EMAC_INT_STATUS);
writel(adpt->irq.mask, adpt->base + EMAC_INT_MASK);
+ /* Enable pause frames. Without this feature, the EMAC has been shown
+ * to receive (and drop) frames with FCS errors at gigabit connections.
+ */
+ adpt->phydev->supported |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
+ adpt->phydev->advertising |= SUPPORTED_Pause | SUPPORTED_Asym_Pause;
+
adpt->phydev->irq = PHY_IGNORE_INTERRUPT;
phy_start(adpt->phydev);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next reply other threads:[~2016-11-01 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 18:30 Timur Tabi [this message]
2016-11-01 18:30 ` [PATCH 2/2] net: qcom/emac: enable flow control if requested Timur Tabi
2016-11-01 18:34 ` Florian Fainelli
2016-11-01 19:05 ` Timur Tabi
2016-11-01 18:33 ` [PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames Florian Fainelli
2016-11-01 18:34 ` Timur Tabi
2016-11-01 18:40 ` [PATCH 0/2] net: qcom/emac: the emac driver requires " Timur Tabi
-- strict thread matches above, loose matches on Subject: below --
2016-11-07 16:51 [PATCH 0/2] net: qcom/emac: ensure that pause frames are enabled Timur Tabi
2016-11-07 16:51 ` [PATCH 1/2] net: qcom/emac: configure the external phy to allow pause frames Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478025055-13167-1-git-send-email-timur@codeaurora.org \
--to=timur@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox