From: David Woodhouse <dwmw2@infradead•org>
To: Russell King - ARM Linux <linux@armlinux•org.uk>, netdev@vger•kernel.org
Cc: qemu-devel@nongnu•org
Subject: Re: TCP performance problems - GSO/TSO, MSS, 8139cp related
Date: Fri, 11 Nov 2016 21:23:43 +0000 [thread overview]
Message-ID: <1478899423.3892.7.camel@infradead.org> (raw)
In-Reply-To: <20161111210500.GE1041@n2100.armlinux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]
On Fri, 2016-11-11 at 21:05 +0000, Russell King - ARM Linux wrote:
>
> 18:59:38.782818 IP (tos 0x0, ttl 52, id 35619, offset 0, flags [DF], proto TCP (6), length 60)
> 84.xx.xxx.196.61236 > 195.92.253.2.http: Flags [S], cksum 0x88db (correct), seq 158975430, win 29200, options [mss 1452,sackOK,TS val 1377914597 ecr 0,nop,wscale 7], length 0
... (MSS 1452)
> 18:59:38.816371 IP (tos 0x0, ttl 64, id 25879, offset 0, flags [DF], proto TCP (6), length 1500)
> 195.92.253.2.http > 84.xx.xxx.196.61236: Flags [.], seq 1:1449, ack 154, win 235, options [nop,nop,TS val 3363137952 ecr 1377914627], length 1448: HTTP, length: 1448
> 18:59:38.816393 IP (tos 0x0, ttl 64, id 25880, offset 0, flags [DF], proto TCP (6), length 1484)
> 195.92.253.2.http > 84.xx.xxx.196.61236: Flags [.], seq 1449:2881, ack 154, win 235, options [nop,nop,TS val 3363137952 ecr 1377914627], length 1432: HTTP
Can you instrument cp_start_xmit() in 8139cp.c and get it to print the
value of 'mss' when this happens?
All we do is take that value from skb_shinfo(skb)->gso_size, shift it a
bit, and shove it in the descriptor ring. There's not much scope for a
driver-specific bug.
It's also *fairly* unlikely that the kernel in the guest has developed
a bug and isn't setting gso_size sanely. I'm more inclined to suspect
that qemu isn't properly emulating those bits. But at first glance at
the code, it looks like *that's* been there for the last decade too...
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5760 bytes --]
next prev parent reply other threads:[~2016-11-11 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 21:05 TCP performance problems - GSO/TSO, MSS, 8139cp related Russell King - ARM Linux
2016-11-11 21:23 ` David Woodhouse [this message]
2016-11-11 22:33 ` Russell King - ARM Linux
2016-11-12 2:52 ` David Miller
2016-11-11 22:44 ` Russell King - ARM Linux
2016-11-14 9:29 ` [Qemu-devel] " Dr. David Alan Gilbert
2016-11-14 16:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478899423.3892.7.camel@infradead.org \
--to=dwmw2@infradead$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qemu-devel@nongnu$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox