From: Joe Perches <joe@perches•com>
To: Pavel Machek <pavel@ucw•cz>
Cc: peppe.cavallaro@st•com, netdev@vger•kernel.org,
kernel list <linux-kernel@vger•kernel.org>,
ezequiel@vanguardiasur•com.ar, sonic.zhang@analog•com,
fabrice.gasnier@st•com
Subject: Re: [PATCH] stmmac ethernet: remove cut & paste code
Date: Mon, 28 Nov 2016 08:03:52 -0800 [thread overview]
Message-ID: <1480349032.17012.1.camel@perches.com> (raw)
In-Reply-To: <20161128143539.GB31224@amd>
On Mon, 2016-11-28 at 15:35 +0100, Pavel Machek wrote:
> On Mon 2016-11-28 06:24:28, Joe Perches wrote:
> > On Mon, 2016-11-28 at 12:50 +0100, Pavel Machek wrote:
> > > On Thu 2016-11-24 14:27:13, Joe Perches wrote:
> > > > On Thu, 2016-11-24 at 22:44 +0100, Pavel Machek wrote:
> > > > > On Thu 2016-11-24 12:05:25, Joe Perches wrote:
> > > > > > On Thu, 2016-11-24 at 12:05 +0100, Pavel Machek wrote:
> > > > > > > Remove duplicate code from _tx routines.
> > > > > >
> > > > > > trivia:
> > > > > >
> > > > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > > > > >
> > > > > > []
> > > > > > > @@ -1960,6 +1960,38 @@ static void stmmac_tso_allocator(struct stmmac_priv *priv, unsigned int des,
> > > > > > > }
> > > > > > > }
> > > > > > >
> > > > > > > +static void stmmac_xmit_common(struct sk_buff *skb, struct net_device *dev, int nfrags, struct dma_desc *desc)
> > > > > > > +{
> > > > > > > + struct stmmac_priv *priv = netdev_priv(dev);
> > > > > > > +
> > > > > > > + if (unlikely(stmmac_tx_avail(priv) <= (MAX_SKB_FRAGS + 1))) {
> > > > > > > + if (netif_msg_hw(priv))
> > > > > > > + pr_debug("%s: stop transmitted packets\n", __func__);
> > > > > >
> > > > > > netif_dbg(priv, hw, dev, "%s: stop transmitted packets\n",
> > > > > > __func__);
> > > > >
> > > > > Not now. Modifying the code while de-duplicating would be bad idea.
> > > >
> > > > Too many people think overly granular patches are the
> > > > best and only way to make changes.
> > > > Deduplication and consolidation can happen simultaneously.
> > >
> > > Can, but should not at this point. Please take a look at the driver in
> > > question before commenting on trivial printk style.
> >
> > I had.
> >
> > It's perfectly acceptable and already uses netif_<level> properly.
> >
> > This consolidation now introduces the _only_ instance where it is
> > now improperly using a netif_msg_<type> then single pr_<level>
> > function sequence that should be consolidated into netif_dbg.
> > Every other use of netif_msg_<level> then either emits multiple
> > lines or is used in an if/else.
>
> Are you looking at right driver?
Yes and I think you should make changes against -next
and not Linus' where this is:
b3e51069627e2 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c (LABBE Corentin 2016-11-16 20:09:41 +0100 755) netif_warn(priv, link, priv->dev,
b3e51069627e2 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c (LABBE Corentin 2016-11-16 20:09:41 +0100 756) "Speed (%d) not 10/100\n",
b3e51069627e2 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c (LABBE Corentin 2016-11-16 20:09:41 +0100 757) phydev->speed);
> I don't see single use of
> netif_msg_<level>, but see this at stmmac_main.c:756. Code is actually
> pretty consistent using pr_*.
>
> if (netif_msg_link(priv))
> pr_warn("%s: Speed (%d) not 10/100\n",
> dev->name, phydev->speed);
>
> Anyway, I'm moving code around, if you want to do trivial cleanups, do
> them yourself.
cheers, Joe
next prev parent reply other threads:[~2016-11-28 16:03 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:51 stmmac ethernet in kernel 4.4: coalescing related pauses? Pavel Machek
2016-11-24 8:55 ` stmmac ethernet in kernel 4.9-rc6: coalescing related pauses Pavel Machek
2016-11-24 10:29 ` Pavel Machek
2016-11-24 10:36 ` Pavel Machek
2016-11-24 10:46 ` [PATCH] stmmac ethernet: unify locking Pavel Machek
2016-11-24 11:05 ` [PATCH] stmmac ethernet: remove cut & paste code Pavel Machek
2016-11-24 20:05 ` Joe Perches
2016-11-24 21:44 ` Pavel Machek
2016-11-24 22:27 ` Joe Perches
2016-11-28 11:50 ` Pavel Machek
2016-11-28 14:24 ` Joe Perches
2016-11-28 14:35 ` Pavel Machek
2016-11-28 16:03 ` Joe Perches [this message]
2016-11-24 16:04 ` stmmac ethernet in kernel 4.9-rc6: coalescing related pauses David Miller
2016-11-24 21:25 ` Pavel Machek
2016-12-02 8:24 ` Giuseppe CAVALLARO
2016-12-02 8:41 ` Giuseppe CAVALLARO
2016-12-02 8:45 ` Pavel Machek
2016-12-02 9:43 ` Giuseppe CAVALLARO
2016-12-02 12:32 ` Pavel Machek
2016-12-02 13:51 ` Giuseppe CAVALLARO
2016-12-02 14:26 ` Alexandre Torgue
2016-12-02 15:19 ` Giuseppe CAVALLARO
2016-12-05 12:14 ` Pavel Machek
2016-12-05 12:01 ` Pavel Machek
2016-12-05 10:15 ` Pavel Machek
2016-12-05 11:40 ` Lino Sanfilippo
2016-12-05 22:02 ` Pavel Machek
2016-12-05 22:37 ` Lino Sanfilippo
2016-12-05 22:40 ` Pavel Machek
2016-12-05 22:54 ` Lino Sanfilippo
2016-12-05 23:11 ` Lino Sanfilippo
2016-12-02 14:05 ` Aw: " Lino Sanfilippo
2016-12-07 12:31 ` [RFC] " Pavel Machek
2016-12-07 13:18 ` Lino Sanfilippo
2016-12-05 11:56 ` Pavel Machek
2016-11-28 11:55 ` [PATCH] stmmac: fix comments, make debug output consistent Pavel Machek
2016-11-30 0:53 ` David Miller
2016-11-28 12:13 ` stmmac ethernet in kernel 4.9-rc6: coalescing related pauses Pavel Machek
2016-11-28 12:17 ` [PATCH] stmmac: reduce code duplication getting basic descriptors Pavel Machek
2016-11-28 15:25 ` kbuild test robot
2016-12-02 14:09 ` Alexandre Torgue
2016-11-30 11:44 ` [PATCH] stmmac: simplify flag assignment Pavel Machek
2016-12-01 20:23 ` David Miller
2016-12-01 22:48 ` stmmac: turn coalescing / NAPI off in stmmac Pavel Machek
2016-12-02 8:39 ` Giuseppe CAVALLARO
2016-12-02 10:42 ` Pavel Machek
2016-12-02 15:31 ` Giuseppe CAVALLARO
2016-12-05 11:45 ` Pavel Machek
2016-12-02 8:27 ` [PATCH] stmmac: simplify flag assignment Giuseppe CAVALLARO
2016-12-01 10:32 ` [PATCH] stmmac: cleanup documenation, make it match reality Pavel Machek
2016-12-03 20:07 ` David Miller
2016-12-05 12:27 ` [PATCH] stmmac: disable tx coalescing Pavel Machek
2016-12-11 19:07 ` Pavel Machek
2016-12-11 19:31 ` David Miller
2016-12-11 19:57 ` Pavel Machek
2016-11-28 13:07 ` stmmac ethernet in kernel 4.4: coalescing related pauses? Lino Sanfilippo
2016-11-28 14:54 ` David Miller
2016-11-28 15:31 ` Eric Dumazet
2016-11-28 15:57 ` Lino Sanfilippo
2016-11-28 16:30 ` David Miller
2016-11-28 17:01 ` Lino Sanfilippo
2016-11-30 10:28 ` Pavel Machek
2016-11-28 15:33 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480349032.17012.1.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=ezequiel@vanguardiasur$(echo .)com.ar \
--cc=fabrice.gasnier@st$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel@ucw$(echo .)cz \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=sonic.zhang@analog$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox