Subject: Re: [PATCH] net: wan: Use dma_pool_zalloc

From: Joe Perches <[email-masked]>
Date: Thu, 15 Dec 2016 08:48:07 -0800

On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
> On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder <[email-masked]> wrote:
> > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa <[email-masked]> wrote:
> > > Souptick Joarder <[email-masked]> writes:
> > > 
> > > > We should use dma_pool_zalloc instead of dma_pool_alloc/memset
[]
> > > > diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
[]
> > > > @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
> > > >                       return -ENOMEM;
> > > >       }
> > > > 
> > > > -     if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
> > > > -                                           &port->desc_tab_phys)))
> > > > +     if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
> > > > +                                            &port->desc_tab_phys)))
> > > >               return -ENOMEM;
> > > > -     memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
> > > >       memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
> > > >       memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
> > > 
> > > This look fine, feel free to send it to the netdev mailing list for
> > > inclusion.
> > 
> > Including netdev mailing list based as requested.
> > > Acked-by: Krzysztof Halasa <[email-masked]>
[]
> Any comment on this patch ?

Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
also be changed?