From: Joe Perches <joe@perches•com>
To: Souptick Joarder <jrdr.linux@gmail•com>
Cc: "Krzysztof Hałasa" <khalasa@piap•pl>,
netdev@vger•kernel.org,
"Rameshwar Sahu" <sahu.rameshwar73@gmail•com>
Subject: Re: [PATCH] net: wan: Use dma_pool_zalloc
Date: Thu, 15 Dec 2016 22:10:49 -0800 [thread overview]
Message-ID: <1481868649.29291.85.camel@perches.com> (raw)
In-Reply-To: <CAFqt6zaPWuc+gZTMqk-gh8weZvAjvVwm0kyDT5ub=iah=y9skA@mail.gmail.com>
On Fri, 2016-12-16 at 11:33 +0530, Souptick Joarder wrote:
> On Thu, Dec 15, 2016 at 10:18 PM, Joe Perches <joe@perches•com> wrote:
> > On Thu, 2016-12-15 at 10:41 +0530, Souptick Joarder wrote:
> > > On Mon, Dec 12, 2016 at 10:12 AM, Souptick Joarder <jrdr.linux@gmail•com> wrote:
> > > > On Fri, Dec 9, 2016 at 6:33 PM, Krzysztof Hałasa <khalasa@piap•pl> wrote:
> > > > > Souptick Joarder <jrdr.linux@gmail•com> writes:
> > > > >
> > > > > > We should use dma_pool_zalloc instead of dma_pool_alloc/memset
> >
> > []
> > > > > > diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
> >
> > []
> > > > > > @@ -976,10 +976,9 @@ static int init_hdlc_queues(struct port *port)
> > > > > > return -ENOMEM;
> > > > > > }
> > > > > >
> > > > > > - if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
> > > > > > - &port->desc_tab_phys)))
> > > > > > + if (!(port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
> > > > > > + &port->desc_tab_phys)))
> > > > > > return -ENOMEM;
> > > > > > - memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
> > > > > > memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
> > > > > > memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));
> > > > >
> > > > > This look fine, feel free to send it to the netdev mailing list for
> > > > > inclusion.
> > > >
> > > > Including netdev mailing list based as requested.
> > > > > Acked-by: Krzysztof Halasa <khalasa@piap•pl>
> >
> > []
> > > Any comment on this patch ?
> >
> > Shouldn't the one in drivers/net/ethernet/xscale/ixp4xx_eth.c
> > also be changed?
>
> Yes, you are right. Do you want me to include it in same patch?
Your choice. I would use a single patch.
next prev parent reply other threads:[~2016-12-16 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161203091447.GA5231@jordon-HP-15-Notebook-PC>
[not found] ` <m3wpf9l0fc.fsf@t19.piap.pl>
2016-12-12 4:42 ` [PATCH] net: wan: Use dma_pool_zalloc Souptick Joarder
2016-12-15 5:11 ` Souptick Joarder
2016-12-15 16:48 ` Joe Perches
2016-12-16 6:03 ` Souptick Joarder
2016-12-16 6:10 ` Joe Perches [this message]
2016-12-16 13:55 ` Souptick Joarder
2016-12-17 0:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481868649.29291.85.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=jrdr.linux@gmail$(echo .)com \
--cc=khalasa@piap$(echo .)pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sahu.rameshwar73@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox