From: Teresa Remmet <t.remmet@phytec•de>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Alexandru Gagniuc <alex.g@adaptrum•com>,
"David S. Miller" <davem@davemloft•net>,
Mugunthan V N <mugunthanvnm@ti•com>,
Grygorii Strashko <grygorii.strashko@ti•com>,
linux-omap@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: net: ti: cpsw-phy-sel: RGMII is not working on AM335x
Date: Wed, 11 Jan 2017 16:57:35 +0100 [thread overview]
Message-ID: <1484150255.3777.13.camel@phytec.de> (raw)
In-Reply-To: <20170111151407.GW22820@lunn.ch>
Hello Andrew,
Am Mittwoch, den 11.01.2017, 16:14 +0100 schrieb Andrew Lunn:
> >
> > So I wonder what is correct now? As for me the patch makes RGMII
> > unusable.
> > Has anyone an explanation?
> Hi Teresa
>
> In your device tree, what phy-mode do you have?
>
> And does your hardware require an RGMII delay in order that it works?
my device tree node for the RGMII looks like this:
&cpsw_emac1 {
phy-handle = <&phy1>;
phy-mode = "rgmii";
dual_emac_res_vlan = <2>;
status = "okay";
};
&davinci_mdio {
phy1: ethernet-phy@1 {
reg = <2>;
/* Register 260 (104h) – RGMII Clock and Control Pad Skew */ rxc-skew-ps = <1400>;
rxdv-skew-ps = <0>;
txc-skew-ps = <1400>;
txen-skew-ps = <0>;
/* Register 261 (105h) – RGMII RX Data Pad Skew */
rxd3-skew-ps = <0>;
rxd2-skew-ps = <0>;
rxd1-skew-ps = <0>;
rxd0-skew-ps = <0>;
/* Register 262 (106h) – RGMII TX Data Pad Skew */
txd3-skew-ps = <0>;
txd2-skew-ps = <0>;
txd1-skew-ps = <0>;
txd0-skew-ps = <0>;
};
};
The phy we use is a KSZ9021. And yes we add delays to the
phy, as you can see. When looking to the dts documentation I probably
need to set the phy-mode to "rgmii-id" instead, as the phy is providing
the delays.
I make a quick test with that change and it is working. So this seems
to solve my problem. Thank you for the hint.
Regards,
Teresa
>
> Andrew
next prev parent reply other threads:[~2017-01-11 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 8:14 net: ti: cpsw-phy-sel: RGMII is not working on AM335x Teresa Remmet
2017-01-11 15:14 ` Andrew Lunn
2017-01-11 15:57 ` Teresa Remmet [this message]
2017-01-11 20:18 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484150255.3777.13.camel@phytec.de \
--to=t.remmet@phytec$(echo .)de \
--cc=alex.g@adaptrum$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox