From: Joe Perches <joe@perches•com>
To: David VomLehn <vomlehn@texas•net>,
Alexander Loktionov <Alexander.Loktionov@aquantia•com>,
netdev@vger•kernel.org
Cc: "David S . Miller" <davem@davemloft•net>,
Simon Edelhaus <Simon.Edelhaus@aquantia•com>,
Dmitrii Tarakanov <Dmitrii.Tarakanov@aquantia•com>,
Pavel Belous <Pavel.Belous@aquantia•com>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia•com>
Subject: Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.
Date: Thu, 12 Jan 2017 23:28:45 -0800 [thread overview]
Message-ID: <1484292525.3065.29.camel@perches.com> (raw)
In-Reply-To: <ce83519e-18bf-b202-7a0f-c217ab8aa189@texas.net>
On Thu, 2017-01-12 at 22:57 -0800, David VomLehn wrote:
> On 01/12/2017 09:59 PM, Joe Perches wrote:
> > On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote:
> > > On 01/12/2017 09:06 PM, Joe Perches wrote:
> > > > On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote:
> > > > > From: David VomLehn <vomlehn@texas•net>
> > > > >
> > > > > Patches to create the make and configuration files.
> > > >
> > > > This patch should _really_ be the last in the series
> > > > not the first.
> > > >
> > >
> > > Could you explain the basis for this? By convention, we put tables of
> > > content at the beginning of books and only indices at the back.
> > > Analogously, make and config files can be used to established the
> > > context for what follows, making it easier to understand. Once
> > > committed, of course, the order no longer matters except as bisection is
> > > concerned.
> >
> > As I wrote the first time:
> >
> > On Tue, 2016-12-27 at 08:15 -0800, Joe Perches wrote:
> > > On Tue, 2016-12-27 at 05:17 -0800, David VomLehn wrote:
> > > > Patches to create the make and configuration files.
> >
> > []
> > > Patch 1 will not build if CONFIG_AQTION is enabled.
> > > Patch 1/12 should be reordered to be patch 12/12 and
> > > all the other patches moved up appropriately.
> >
> > You don't create the files until later patches.
> >
> > If you applied just this first patch and tried to
> > add CONFIG_AQTION=y to the .config, make fails.
> >
> > That's bad for git bisect.
> > Every patch in this series should build properly.
> >
> > If you delay the adding of the Makefile and Kconfig
> > until all the files are added, then it'd bisect fine.
>
> Please go back and re-read the latest patches; I think you will find
> your concern about CONFIG_AQTION addressed in the v5 patchset. The 01/13
> patch no longer has the changes to Makefile and Kconfig in
> drivers/net/ethernet that will pull in the Makefile and Kconfig from
> drivers/net/ethernet/aquantia. Those changes are now in the 13/13 patch,
> which should make it bisectable. If I am missing something, please let
> me know.
Well fine then.
I just looked subject titles and didn't notice that change.
cheers, Joe
next prev parent reply other threads:[~2017-01-13 7:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 5:02 [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 03/13] net: ethernet: aquantia: Add ring support code Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 04/13] net: ethernet: aquantia: Low-level hardware interfaces Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 07/13] net: ethernet: aquantia: Vector operations Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 08/13] net: ethernet: aquantia: PCI operations Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 10/13] net: ethernet: aquantia: Hardware interface and utility functions Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 11/13] net: ethernet: aquantia: Ethtool support Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 12/13] net: ethernet: aquantia: Receive side scaling Alexander Loktionov
2017-01-13 5:02 ` [PATCH v5 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-14 1:47 ` [PATCH v5 11/13] net: ethernet: aquantia: Ethtool support Florian Fainelli
2017-01-14 1:48 ` [PATCH v5 08/13] net: ethernet: aquantia: PCI operations Florian Fainelli
2017-01-14 2:00 ` [PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code Florian Fainelli
2017-01-14 22:55 ` Rami Rosen
2017-01-15 1:15 ` Andrew Lunn
2017-01-14 1:32 ` [PATCH v5 02/13] net: ethernet: aquantia: Common functions and definitions David Miller
2017-01-13 5:06 ` [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files Joe Perches
2017-01-13 5:24 ` David VomLehn
2017-01-13 5:59 ` Joe Perches
2017-01-13 6:57 ` David VomLehn
2017-01-13 7:28 ` Joe Perches [this message]
2017-01-14 2:01 ` Florian Fainelli
2017-01-14 18:39 ` Florian Fainelli
2017-01-14 18:42 ` David VomLehn
2017-01-14 18:48 ` Florian Fainelli
2017-01-14 19:04 ` David VomLehn
2017-01-14 1:38 ` [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Florian Fainelli
2017-01-14 3:41 ` David VomLehn
2017-01-14 2:05 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484292525.3065.29.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=Alexander.Loktionov@aquantia$(echo .)com \
--cc=Dmitrii.Tarakanov@aquantia$(echo .)com \
--cc=Dmitry.Bezrukov@aquantia$(echo .)com \
--cc=Pavel.Belous@aquantia$(echo .)com \
--cc=Simon.Edelhaus@aquantia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vomlehn@texas$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox