From: Oliver Neukum <oneukum-IBi9RG/b67k@public•gmane.org>
To: Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Greg Ungerer <gerg-Td1EMuHUCqxL1ZNQvxDV9g@public•gmane.org>
Cc: bjorn-yOkvZcmFvRU@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver
Date: Tue, 28 Mar 2017 10:01:40 +0200 [thread overview]
Message-ID: <1490688100.29898.1.camel@suse.com> (raw)
In-Reply-To: <1490365070.9687.46.camel-XN9IlZ5yJG9HTL0Zs8A6p+yfmBU6pStAUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
Am Freitag, den 24.03.2017, 07:17 -0700 schrieb Eric Dumazet:
> On Fri, 2017-03-24 at 15:42 +1000, Greg Ungerer wrote:
>
> >
> > The usbnet core is used by a number of drivers. This patch only
> > updates the qmi-wwan driver to use stats64. If you remove the
> > dev->stats.rx_* updates all those other driver users will have
> > no counts.
>
> I see. Then I guess the u64 stuff could be done only if running 32bit
> kernels. (The existing stats are using 'unsigned long' so are already
> 64bit wide on 64bit kernels)
We want every driver to use u64 if possible. If something
is exported we want a defined size.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-03-28 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 1:27 [PATCHv2] net: usbnet: support 64bit stats in qmi_wwan driver Greg Ungerer
[not found] ` <1490318850-23252-1-git-send-email-gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2017-03-24 4:59 ` Eric Dumazet
2017-03-24 5:42 ` Greg Ungerer
2017-03-24 14:17 ` Eric Dumazet
[not found] ` <1490365070.9687.46.camel-XN9IlZ5yJG9HTL0Zs8A6p+yfmBU6pStAUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2017-03-28 8:01 ` Oliver Neukum [this message]
2017-03-24 18:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490688100.29898.1.camel@suse.com \
--to=oneukum-ibi9rg/b67k@public$(echo .)gmane.org \
--cc=bjorn-yOkvZcmFvRU@public$(echo .)gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=gerg-Td1EMuHUCqxL1ZNQvxDV9g@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox