Subject: Re: [PATCH] ipv4: netfilter: Comparison to NULL could be written

From: Joe Perches <[email-masked]>
Date: Sat, 01 Apr 2017 06:05:59 -0700

On Sat, 2017-04-01 at 14:05 +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons to be more
> consistant with the rest of the kernel coding style.

typo: consistent and trivia:

> diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
[]
> @@ -653,7 +653,7 @@ static struct xt_counters *alloc_counters(const struct xt_table *table)
>  	countersize = sizeof(struct xt_counters) * private->number;
>  	counters = vzalloc(countersize);
>  
> -	if (counters == NULL)
> +	if (!counters)
>  		return ERR_PTR(-ENOMEM);

This could also remove the blank link above the test.