Subject: Re: [PATCH net-next v5 3/5] netlink: allow sending extended ACK with cookie on success

From: Johannes Berg <[email-masked]>
Date: Wed, 12 Apr 2017 15:54:31 +0200

> > 	} else {
> > 		flags |= NLM_F_CAPPED;
> > +
> > +		if (nlk->flags & NETLINK_F_EXT_ACK &&
> > +		    extack && extack->cookie_len)
> > +			tlvlen += nla_total_size(extack-
> > >cookie_len);
> > 	}
> > 
> 
> Now I see why you have "if (tlvlen)" where you have it :)

Ah, you had me wondering with that comment ... Yeah, I'd been
developing this by adding patches and then rebasing, so the fact that
this could've been elsewhere to start with never crossed my mind.

johannes