Subject: Re: [PATCH] xdp: use common helper for netlink extended ack reporting

From: Johannes Berg <[email-masked]>
Date: Wed, 03 May 2017 07:32:18 +0200

On Wed, 2017-05-03 at 00:39 +0200, Daniel Borkmann wrote:
> Small follow-up to d74a32acd59a ("xdp: use netlink extended ACK
> reporting")
> in order to let drivers all use the same NL_SET_ERR_MSG_MOD() helper
> macro
> for reporting. This also ensures that we consistently add the
> driver's
> prefix for dumping the report in user space to indicate that the
> error
> message is driver specific and not coming from core code.
> Furthermore,
> NL_SET_ERR_MSG_MOD() now reuses NL_SET_ERR_MSG() and thus makes all
> macros
> check the pointer as suggested.
> 
> References: https://www.spinics.net/lists/netdev/msg433267.html
> Signed-off-by: Daniel Borkmann <[email-masked]>

I did wonder about the whole _TRY_ thing. LGTM

Reviewed-by: Johannes Berg <[email-masked]>

johannes