From: yuan linyu <cugyly@163•com>
To: 吉藤英明 <hideaki.yoshifuji@miraclelinux•com>
Cc: network dev <netdev@vger•kernel.org>,
"David S . Miller" <davem@davemloft•net>,
Joe Perches <joe@perches•com>, David Ahern <dsahern@gmail•com>,
yuan linyu <Linyu.Yuan@alcatel-sbell•com.cn>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue
Date: Sat, 27 May 2017 06:08:17 +0800 [thread overview]
Message-ID: <1495836497.2536.4.camel@163.com> (raw)
In-Reply-To: <CAPA1RqB1_ObcZc_rgE6HN+-PzsabWd2X=swGbkPxVLrzY60MKg@mail.gmail.com>
On 六, 2017-05-27 at 02:25 +0900, 吉藤英明 wrote:
> Hi,
>
> 2017-05-26 22:55 GMT+09:00 yuan linyu <cugyly@163•com>:
> >
> > On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote:
> > >
> > > Hi,
> > >
> > > 2017-05-26 22:23 GMT+09:00 yuan linyu <cugyly@163•com>:
> > > >
> > > >
> > > > From: yuan linyu <Linyu.Yuan@alcatel-sbell•com.cn>
> > > >
> > > > Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell•com.cn>
> > > > ---
> > > > net/ipv6/ndisc.c | 109 ++++++++++++++++++++++++++++---------------------------
> > > > 1 file changed, 55 insertions(+), 54 deletions(-)
> > > Sorry, I don't think this kind of change for style is good
> > > bacause this makes effort of backport more difficult.
> > hi, i can't understand.
> > if any change of this code you decide to backport, it need effort,
> > not only important fix.
> >
> > do I miss your point ?
> Please let us minimize our effort when doing so.
>
> If the style is not changed, we have more chance to apply the patch
> itself on top of old tree.
>
> Thank you.
I don't know you hate this kind of changes,
from a code reader view, I like to see code with good style.
I am not happy when reading code with this kind of bad style.
And it only spend a command time to backport, right?
it will never spend your effort only if this code will not change in future.
>
> >
> > >
> > >
> > > --yoshfuji
> > >
> >
prev parent reply other threads:[~2017-05-26 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 13:23 [PATCH net-next 1/2] net: ndisc.c: fix coding style issue yuan linyu
2017-05-26 13:45 ` 吉藤英明
2017-05-26 13:55 ` yuan linyu
2017-05-26 17:25 ` 吉藤英明
2017-05-26 22:08 ` yuan linyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495836497.2536.4.camel@163.com \
--to=cugyly@163$(echo .)com \
--cc=Linyu.Yuan@alcatel-sbell$(echo .)com.cn \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=hideaki.yoshifuji@miraclelinux$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox